Speed up QSTR creation by pre-filtering files before pre-processing. #1079
Conversation
ports/atmel-samd/Makefile
Outdated
| @@ -427,6 +427,7 @@ endif | |||
| OBJ += $(addprefix $(BUILD)/, $(SRC_S:.s=.o)) | |||
|
|
|||
| SRC_QSTR += $(SRC_C) $(SRC_SUPERVISOR) $(SRC_COMMON_HAL_EXPANDED) $(SRC_SHARED_MODULE_EXPANDED) $(STM_SRC_C) | |||
| SRC_QSTR_PP += peripherals/samd/$(CHIP_FAMILY)/clocks.c | |||
There was a problem hiding this comment.
Could you just put in a comment saying the SRC_QSTR_PP files are files that generate QSTRs via a preprocessor macor, or rename it to SRC_QSTR_FROM_PREPROCESSOR or something like that?
| SRC_QSTR = $(SRC_MOD) $(filter-out $(SRC_QSTR_IGNORE),$(PY_CORE_O_BASENAME:.o=.c)) $(PY_EXTMOD_O_BASENAME:.o=.c) | ||
| # Sources that only hold QSTRs after pre-processing. |
There was a problem hiding this comment.
OK, I see the comment here, but maybe rename it to SRC_QSTR_PREPROCESSOR or SRC_QSTR_CPP.
|
As an alternative to listing SRC_QSTR_PREPROCESSOR, you could just add special comments in the source that isn't otherwise caught by grep, |
|
@jepler I thought about that but this approach keeps it centralized. Both cases are kinda gross (qstr in peripherals and a .c that's included) so hopefully its short term. |
Looks to save 15 seconds or so. The compiler catches when this fails because the QSTR is missing when it does.