8000 fix samd usb hid typo by hathach · Pull Request #1076 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

fix samd usb hid typo #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2018
Merged

fix samd usb hid typo #1076

merged 1 commit into from
Aug 1, 2018

Conversation

hathach
Copy link
Member
@hathach hathach commented Aug 1, 2018

saw a couple of typos in usb hid. However, I didn't have samd board to test with, please double check to make sure this doesn't break anything.

@hathach hathach requested review from tannewt and dhalbert August 1, 2018 01:43
@jerryneedell
Copy link
Collaborator
jerryneedell commented Aug 1, 2018 •
edited
Loading

@hathach I tried the same test

from adafruit_hid.mouse import Mouse

m = Mouse()

# Click the left mouse button.
m.click(Mouse.LEFT_BUTTON)

# Move the mouse diagonally to the upper left.
m.move(-100, -100, 0)

on a feather m4 express with this PR and it also works.

@jerryneedell
Copy link
Collaborator

It looks like the changes deal with the KEYBOARD, so this mouse test may not have been very meaningful.

@hathach
Copy link
Member Author
hathach commented Aug 1, 2018 •
edited
Loading

@jerryneedell the extern with usb_hid_devices could be confusing as well. Some files may not linked to the correct isntance. Your test with mouse is also meaningful.

@jerryneedell
Copy link
Collaborator

@hathach also tried this and it works

>>> from adafruit_hid.keyboard import Keyboard
>>> from adafruit_hid.keycode import Keycode
>>> kbd =Keyboard()
>>> kbd.send(Keycode.A)
>>> a
>>> kbd.send(Keycode.SHIFT,Keycode.A)
>>> A

@hathach
Copy link
Member Author
hathach commented Aug 1, 2018

👍

dhalbert
dhalbert approved these changes Aug 1, 2018
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! Thanks @jerryneedell for testing!

@dhalbert dhalbert merged commit 6333cff into adafruit:master Aug 1, 2018
@hathach hathach deleted the samd_usbhid_typo branch December 17, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hathach @jerryneedell @dhalbert
0