forked from micropython/micropython
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Micropython 25ae98f merge #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tannewt
merged 839 commits into
adafruit:master
from
dhalbert:micropython-25ae98f-merge
Jul 30, 2018
Merged
Changes from all commits
Commits
Show all changes
839 commits
Select commit
Hold shift + click to select a range
d4f8414
stm32/adc: Use mp_hal_pin_config() instead of HAL_GPIO_Init().
dpgeorge dcfd2de
stm32/dac: Make deinit disable the output buffer on H7 and L4 MCUs.
dpgeorge 00a659f
stm32/dac: Implement printing of a DAC object.
dpgeorge edb600b
stm32/mphalport: Optimise the way that GPIO clocks are enabled.
dpgeorge 4c0f664
stm32/flash: Remove unused src parameter from flash_erase().
dpgeorge 2664466
stm32/dma: Always deinit/reinit DMA channels on L4 MCUs.
doc-hex a03e6c1
stm32/irq: Define IRQ priorities directly as encoded hardware values.
dpgeorge 051686b
stm32/main: Clean up and optimise initial start-up code of the MCU.
dpgeorge db2bdad
tests/pyb: Update tests to run correctly on PYBv1.0.
dpgeorge 6410e17
esp8266: Disable DEBUG_PRINTERS for 512k build.
dpgeorge 60db809
py/builtinhelp: Change occurrence of mp_uint_t to size_t.
dpgeorge 89b1c4a
extmod/vfs: Delegate import_stat to vfs.stat to allow generic FS import.
dpgeorge 5eb198c
tests/run-tests: Support esp32 as a target for running the test suite.
aykevl fb7dabb
esp32/README: Add --init to submodule update command.
torwag 6681eb8
esp32/modsocket: Correctly handle reading from a peer-closed socket.
dpgeorge 4fa7d36
esp32: Use mp_rom_map_elem_t and MP_ROM_xxx macros for const dicts.
dpgeorge 5936168
extmod/uzlib: Fix C-language sequencing error with uzlib_get_byte calls.
dpgeorge 12a3fcc
esp32/modsocket: Check for pending events during blocking socket calls.
dpgeorge 318f874
extmod/modlwip: In ioctl handle case when socket is in an error state.
dpgeorge b614dc7
stm32/dma: Fix duplicate typedef of struct, it's typedef'd in dma.h.
dpgeorge cb3456d
stm32: Don't use %lu or %lx for formatting, use just %u or %x.
dpgeorge aea71db
stm32/Makefile: Use -O2 to optimise compilation of lib/libc/string0.c.
dpgeorge 3cf02be
py/emitnx86: Fix 32-bit x86 native emitter build by including header.
dpgeorge 4b5111f
tests/cpydiff: Remove core_function_unpacking now that it succeeds.
dpgeorge cd9d71e
tests/cpydiff: Remove types_str_decodeerror now that it succeeds.
dpgeorge 74ab341
tests/cpydiff: Remove working cases from types_float_rounding.
dpgeorge 2ada112
tests/cpydiff: Remove types_int_tobytesfloat now that it doesn't fail.
dpgeorge e638def
stm32/i2c: Make sure stop condition is sent after receiving addr nack.
dpgeorge e1bc854
stm32/usb: Fix broken pyb.have_cdc() so it works again.
dpgeorge c1115d9
stm32/usb: Use correct type for USB HID object.
dpgeorge eb88803
py/{modbuiltins,repl}: Start qstr probing from after empty qstr.
dpgeorge bc87b86
py/runtime: Add mp_load_method_protected helper which catches exceptions
dpgeorge 5298606
py/modbuiltins: Make built-in hasattr work properly for user types.
dpgeorge 7241d90
py/repl: Use mp_load_method_protected to prevent leaking of exceptions.
dpgeorge 29d28c2
py/modbuiltins: In built-in dir make use of mp_load_method_protected.
dpgeorge 3678a6b
py/modbuiltins: Make built-in dir support the __dir__ special method.
dpgeorge b208aa1
stm32/README: Update to reflect current MCU support.
dpgeorge 095d397
py/objdeque: Fix sign extension bug when computing len of deque object.
dpgeorge 6046e68
py/repl: Initialise q_last variable to prevent compiler warnings.
dpgeorge d2c1db1
tests/float/float_parse: Allow test to run on 32-bit archs.
dpgeorge 421b84a
docs: Bump version to 1.9.4.
dpgeorge 7541be5
tests/basics/special_methods2: Enable some additional tests that work.
dpgeorge 9630376
py/mpconfig.h: Be stricter when autodetecting machine endianness.
dpgeorge 9f4eda5
stm32/usbd_conf.h: Remove unused macros and clean up header file.
dpgeorge 56a273e
stm32/usbd_conf: Changes files to unix line endings and apply styling.
dpgeorge abde0fa
stm32/usbdev: Convert files to unix line endings.
dpgeorge 4b3c629
.gitattributes: Remove special text handling of stm32 usbdev files.
dpgeorge aeaace0
stm32/usbdev: Remove unused RxState variable, and unused struct.
dpgeorge 749b161
py/mpstate.h: Adjust start of root pointer section to exclude non-ptrs.
dpgeorge 67e1a4f
esp32: Update to latest ESP IDF version.
wijnen 1f1623d
stm32/usbdev: Be honest about data not being written to HID endpoint.
doc-hex ca36645
stm32/usbd_hid_interface: Address possible race condition vs. interrupt.
doc-hex b21415e
stm32/i2c: Add new hardware I2C driver for F4 MCUs.
dpgeorge ce824bb
stm32/machine_i2c: Use new F4 hardware I2C driver for machine.I2C class.
dpgeorge a0f7b4c
stm32/accel: Switch pyb.Accel to use new C-level I2C API.
dpgeorge 92c5e27
stm32/modpyb: Introduce MICROPY_PY_PYB_LEGACY config option for pyb mod.
dpgeorge 88c26a4
stm32/pyb_i2c: Put pyb.I2C under MICROPY_PY_PYB_LEGACY setting.
dpgeorge fb25c81
stm32/modpyb: Remove unused includes and clean up comments.
dpgeorge ed32284
stm32/usb: Use usbd_cdc_itf_t pointer directly in USB_VCP class.
dpgeorge bf08a99
stm32/usb: Combine CDC lower-layer and interface state into one struct.
dpgeorge ed92d62
stm32/usb: Combine HID lower-layer and interface state into one struct.
dpgeorge 68271a2
stm32/usb: Make CDC endpoint definitions private to core usbdev driver.
dpgeorge 91bca34
stm32/usb: Change CDC tx/rx funcs to take CDC state, not usbdev state.
dpgeorge 2e565cc
stm32/usb: Change HID report funcs to take HID state, not usbdev state.
dpgeorge 47ecbbb
stm32/usb: Add ability to have 2x VCP interfaces on the one USB device.
dpgeorge e6b66f1
stm32/usb: Initialise cdc variable to prevent compiler warnings.
dpgeorge c97607d
py/nlrx86: Use naked attribute on nlr_push for gcc 8.0 and higher.
dpgeorge cdaace1
esp32/modnetwork: Fix STA/AP activate/deactivate for new IDF API.
dpgeorge b9ff46f
stm32: Enable UART7/8 on F4 series that have these peripherals.
wtgRyan 1b7487e
py/vm: Adjust #if logic for gil_divisor so braces are balanced.
dpgeorge a883fe1
py/objfun: Fix variable name in DECODE_CODESTATE_SIZE() macro.
tomlogic 9c20447
extmod/modlwip: Update to work with lwIP v2.0.
dpgeorge 7d7b9cd
lib/lwip: Update lwIP to v2.0.3, tag STABLE-2_0_3_RELEASE.
dpgeorge 94a79f3
esp8266/mpconfigport.h: Add some weak links to common Python modules.
dpgeorge f8a5cd2
esp8266/modnetwork: Return empty str for hostname if STA is inactive.
dpgeorge dd13065
esp8266/modnetwork: Raise ValueError when getting invalid WLAN id.
dpgeorge 1e2a6a8
extmod/modlwip: Set POLLHUP flag for sockets that are new.
dpgeorge 58331e3
esp8266/modmachine: Allow I2C and SPI to be configured out of the build.
dpgeorge 46ce395
py/vm: Use enum names instead of magic numbers in multi-opcode dispatch.
dpgeorge 869024d
py/vm: Improve performance of opcode dispatch when using switch stmt.
dpgeorge 3e6ab82
py/repl: Fix handling of unmatched brackets and unfinished quotes.
Li-Weiwei 708cdb6
stm32: Add support for STM32L496 MCU.
tobbad 4005c63
stm32/boards: Add board ld and af.csv files for STM32L496 MCU.
tobbad 769e37b
stm32/boards: Add config files for new board, STM32L496GDISC.
tobbad 43d08d6
py/misc.h: Add MP_STATIC_ASSERT macro to do static assertions.
dpgeorge 828ce16
py/compile: Change comment about ITER_BUF_NSLOTS to a static assertion.
dpgeorge 3ea0862
tools/pydfu.py: Fix typo in comments.
kebwi 1050045
zephyr/README: Hint about existence of qemu_x86_nommu.
pfalcon 9480c18
zephyr/main: After builtin testsuite, drop to REPL.
pfalcon 080b0be
zephyr/mpconfigport.h: Enable uhashlib and ubinascii modules.
pfalcon 0e52ee9
zephyr/modzsensor: Zephyr sensor subsystem bindings.
pfalcon 7afbc49
zephyr/prj_base.conf: Enable DHCP and group static IPs together.
pfalcon 5a02337
zephyr: Add prj_disco_l475_iot1.conf with sensor drivers.
pfalcon 478410b
zephyr/Makefile: Add kobj_types_h_target to Z_EXPORTS.
pfalcon 2923671
esp32/Makefile: Update to latest ESP IDF version.
dpgeorge afd0701
esp8266: Change UART(0) to attach to REPL via uos.dupterm interface.
dpgeorge bc6c0b2
py/emitbc: Avoid undefined behavior calling memset() with NULL 1st arg.
jepler 5efc575
py/parsenum: Use int instead of mp_int_t for parsing float exponent.
dpgeorge 4f71a2a
py/parsenum: Avoid undefined behavior parsing floats with large expon…
jepler 60eb530
py/objfloat: Fix undefined shifting behavior in high-quality float hash.
jepler c4dafce
py/mpz: Avoid undefined behavior at integer overflow in mpz_hash.
jepler 95e43ef
py/objfloat: Fix undefined integer behavior hashing negative zero.
jepler 1ad0013
tests: Add some tests for bigint hash, float hash and float parsing.
dpgeorge cac2edd
minimal/main: Allow to compile without GC enabled.
DanielShaulov 6bd7874
py/gc: When GC threshold is hit don't unnecessarily collect twice.
dpgeorge 6c95593
stm32/rtc: Don't try to set SubSeconds value on RTC.
dpgeorge 41766ba
extmod/modlwip: Allow to compile with MICROPY_PY_LWIP disabled.
dpgeorge cda9641
stm32: Integrate lwIP as implementation of usocket module.
dpgeorge f68e722
stm32/rng: Use Yasmarang for rng_get() if MCU doesn't have HW RNG.
dpgeorge e773a2c
stm32/main: Use consistent indenting of macro #if's.
dpgeorge f2ec792
py/parsenum: Adjust braces so they are balanced.
dpgeorge b318ebf
py/modbuiltins: Add support for rounding integers.
honza-klu 20b4b85
ports: Enable MICROPY_PY_BUILTINS_ROUND_INT on selected ports.
dpgeorge 771cb35
py/objgenerator: Save state in old_globals instead of local variable.
dpgeorge 400273a
py/objgenerator: Protect against reentering a generator.
dpgeorge 0a25fff
py/emit: Combine fast and deref into one function for load/store/delete.
dpgeorge e686c94
py/emit: Combine yield value and yield-from emit funcs into one.
dpgeorge 26b5754
py/emit: Combine build tuple/list/map emit funcs into one.
dpgeorge d298013
py/emit: Combine name and global into one func for load/store/delete.
dpgeorge a4941a8
py/emit: Combine load/store/delete subscr into one emit function.
dpgeorge 6211d97
py/emit: Combine load/store/delete attr into one emit function.
dpgeorge 8a513da
py/emit: Combine break_loop and continue_loop into one emit function.
dpgeorge d97906c
py/emit: Combine import from/name/star into one emit function.
dpgeorge 436e0d4
py/emit: Merge build set/slice into existing build emit function.
dpgeorge 18e6358
py/emit: Combine setup with/except/finally into one emit function.
dpgeorge df9b7e8
esp32/esp32.custom_common.ld: Put soc code in iram0.
dpgeorge 4200018
stm32: Remove unneeded HTML release notes from usbdev and usbhost dirs.
dpgeorge f47eeab
stm32: Add low-level hardware I2C slave driver.
dpgeorge 15ddc20
stm32: Add new component, the mboot bootloader.
dpgeorge dfeaea1
py/objtype: Remove TODO comment about needing to check for property.
dpgeorge ef4c8e6
esp32: Silence ESP-IDF log messages when in raw REPL mode.
nickzoic aa4a7a8
stm32/usb: Guard USB device code with #if for whether USB is enabled.
dpgeorge f497723
stm32: Allow to have no storage support if there are no block devices.
dpgeorge 070937f
stm32: Add support for Cortex-M0 CPUs.
dpgeorge 5c06859
stm32/timer: Make timer_get_source_freq more efficient by using regs.
dpgeorge 6d83468
stm32: Allow a board to disable MICROPY_VFS_FAT.
dpgeorge 191e2cf
lib/stm32lib: Update library to include support for STM32F0 MCUs.
dpgeorge 4a7d157
stm32/boards: Add startup_stm32f0.s for STM32F0 MCUs.
dpgeorge ea7e747
stm32: Add support for STM32F0 MCUs.
dpgeorge 1163400
stm32/boards: Add alt-func CSV list and linker script for STM32F091.
dpgeorge e681372
stm32/boards: Add NUCLEO_F091RC board configuration files.
dpgeorge 98d1609
stm32/README: Update to include STM32F0 in list of supported MCUs.
dpgeo
8000
rge 50bc34d
stm32/boards: Split combined alt-func labels and fix some other errors.
rolandvs 958fa74
stm32/boards: Ensure USB OTG power is off for NUCLEO_F767ZI.
rolandvs a1acbad
stm32/flash: Increase H7 flash size to full 2MiB.
dpgeorge 05b13fd
py/objtype: Fix assertion failures in mp_obj_new_type by checking types.
jepler c60589c
py/objtype: Fix assertion failures in super_attr by checking type.
jepler 98b9f0f
extmod/modussl_mbedtls: Populate sock member right away in wrap_socket.
dpgeorge ea22406
extmod/modussl_mbedtls: Use mbedtls_entropy_func for CTR-DRBG entropy.
dpgeorge 6d87aa5
stm32/modnetwork: Don't take netif's down when network is deinited.
dpgeorge 7437215
stm32/modnetwork: Change base entry of NIC object from type to base.
dpgeorge d9f1ece
stm32/modnetwork: Provide generic implementation of ifconfig method.
dpgeorge 5a5bc4a
drivers/wiznet5k: Fix bug with MACRAW socket calculating packet size.
dpgeorge 7d86ac6
stm32: Add network driver for Wiznet5k using MACRAW mode and lwIP.
dpgeorge 309fe39
stm32/modnetwork: Fix arg indexing in generic ifconfig method.
dpgeorge 1427f8f
py/stream: Move definition of mp_stream_p_t from obj.h to stream.h.
dpgeorge df13ecd
cc3200/mods: Include stream.h to get definition of mp_stream_p_t.
dpgeorge bc92206
esp32/Makefile: Extract common C & C++ flags for consistent compilation.
projectgus a90124a
esp32: Add support for building with external SPI RAM.
dpgeorge aace60a
esp8266/modules/ntptime.py: Remove print of newly-set time.
dpgeorge 172c23f
extmod/vfs: Use u_rom_obj properly in argument structures.
dpgeorge f35aae3
extmod/vfs_fat: Rename FileIO/TextIO types to mp_type_vfs_fat_XXX.
dpgeorge 8d82b0e
extmod: Add VfsPosix filesystem component.
dpgeorge a93144c
py/reader: Allow MICROPY_VFS_POSIX to work with MICROPY_READER_POSIX.
dpgeorge d4ce57e
extmod/vfs: Add fast path for stating VfsPosix filesystem.
dpgeorge 1d40f12
unix: Support MICROPY_VFS_POSIX and enable it in coverage build.
dpgeorge 6c02da2
tests/extmod: Add test for importing a script from a user VFS.
dpgeorge 5ef0d2a
tests/extmod: Remove conditional import of uos_vfs, it no longer exists.
dpgeorge fadd6bb
unix/moduos_vfs: Add missing uos functions from traditional uos module.
dpgeorge c117eff
extmod/vfs: Introduce a C-level VFS protocol, with fast import_stat.
dpgeorge a8b9e71
py/mpconfig.h: Add default MICROPY_VFS_FAT config value.
dpgeorge b789c64
travis: Install explicit version of urllib3 for coveralls.
dpgeorge db5d8c9
py/obj.h: Introduce a "flags" entry in mp_obj_type_t.
dpgeorge bace1a1
py/objtype: Don't expose mp_obj_instance_attr().
dpgeorge 36c1052
py/objtype: Optimise instance get/set/del by skipping special accessors.
dpgeorge 93150a0
ports: Enable descriptors on stm32, esp8266, esp32 ports.
dpgeorge 190c7db
stm32/mpconfigport.h: Enable DELATTR_SETATTR and BUILTINS_NOTIMPLEMENTED
dpgeorge a12d046
tests/pyb: Make i2c and pyb1 pyboard tests run again.
dpgeorge 039f196
esp32/modnetwork: Fix isconnected() when using static IP config.
glenn20 24c416c
stm32/mboot: Increase USB rx_buf and DFU buf sizes to full 2048 bytes.
dpgeorge 8fb95d6
tools/pydfu.py: Increase download packet size to full 2048 bytes.
dpgeorge 522ea80
py/gc: Add gc_sweep_all() function to run all remaining finalisers.
dpgeorge b2fa1b5
ports: Call gc_sweep_all() when doing a soft reset.
dpgeorge 6a445b6
py/lexer: Add support for underscores in numeric literals.
dpgeorge af0932a
py/modio: Add uio.IOBase class to allow to define user streams.
dpgeorge 565f590
ports: Enable IOBase on unix, stm32, esp8266 and esp32.
dpgeorge 9144b1f
tests/io: Add simple IOBase test.
dpgeorge c901cc6
tests/extmod: Add test for VFS and user-defined filesystem and files.
dpgeorge b045ebd
extmod/moduhashlib: Prefix all Python methods and objects with uhashlib.
Jongy 38682d4
extmod/moduhashlib: Reorder funcs so that they are grouped by hash type.
Jongy 6630354
extmod/moduhashlib: Allow to disable the sha256 class.
Jongy 6963ee9
extmod/moduhashlib: Allow using the sha256 implementation of mbedTLS.
Jongy c2fb725
extmod/moduhashlib: Make function objects STATIC.
Jongy 0501427
esp32: Remove port-specific uhashlib implementation and use common one.
dpgeorge 7ad04d1
py/mkrules.mk: Regenerate all qstrs when config files change.
dpgeorge 5042d98
stm32/Makefile: Rebuild all qstrs when any board configuration changes.
dpgeorge 0359064
extmod/uos_dupterm: Use native C stream methods on dupterm object.
dpgeorge d11fb09
extmod/modussl_axtls: Fix __del__ to point to mp_stream_close_obj.
dpgeorge cf1509c
esp32/fatfs_port: Implement get_fattime so FAT files have a timestamp.
dpgeorge 86fe73b
drivers/memory/spiflash: Move cache buffer to user-provided config.
dpgeorge 335d26b
stm32/boards/STM32L476DISC: Update SPI flash config for cache change.
dpgeorge cc5a940
drivers/memory/spiflash: Rename functions to indicate they use cache.
dpgeorge b78ca32
drivers/memory/spiflash: Add functions for direct erase/read/write.
dpgeorge 37a7257
stm32/timer: Support TIM1 on F0 MCUs.
dpgeorge bc5e8a2
stm32/i2c: Fix num_acks calculation in i2c_write for F0 and F7 MCU's.
dpgeorge 7be4a23
stm32/i2cslave: Fix ordering of event callbacks in slave IRQ handler.
dpgeorge d61d119
esp32: Update to latest ESP IDF.
dpgeorge 34b2f6b
esp32/modules: Include umqtt library in frozen modules.
dpgeorge 8b8c083
drivers/sdcard: Change driver to use new block-device protocol.
dpgeorge 1747d15
drivers/sdcard: Fix bug in computing number of sectors on SD Card.
dpgeorge 564abb0
extmod/vfs_fat_diskio: Factor disk ioctl code to reduce code size.
dpgeorge ceff433
stm32/mboot: Adjust user-reset-mode timeout so it ends with mode=1.
dpgeorge 31cf49c
examples/embedding: Add code markup and fix typo in README.md.
dpgeorge 6abede2
py/stream: Introduce and use efficient mp_get_stream to access stream_p.
dpgeorge e8398a5
extmod: Update to use new mp_get_stream helper.
dpgeorge a5f5552
tests/unix/extra_coverage: Don't test stream objs with NULL write fun.
dpgeorge 0ecce77
tests/extmod/ujson_dump.py: Add test for dump to non-stream object.
dpgeorge 48829cd
tests/extmod: Add test for ujson.dump writing to a user IOBase object.
dpgeorge 0d3de68
stm32/boards/stm32f091_af.csv: Split labels that are multiple funcs.
rolandvs ca2b1d6
stm32/boards/NUCLEO_F091RC: Add Arduino-named pins and rename CPU pins.
rolandvs c00ee20
py/objarray: Replace 0x80 with new MP_OBJ_ARRAY_TYPECODE_FLAG_RW macro.
dpgeorge 338af99
stm32/can: Use MP_OBJ_ARRAY_TYPECODE_FLAG_RW where appropriate.
dpgeorge e49cd10
stm32/spi: Fix SPI driver so it can send/recv more than 65535 bytes.
dpgeorge 6d8816f
tests/import: Add test for importing invalid .mpy file.
dpgeorge 5962c21
stm32/mboot: Define constants for reset mode cycling and timeout.
dpgeorge 561ae9a
stm32/boards/NUCLEO_F091RC: Fix TICK_INT_PRIORITY so it is highest prio.
dpgeorge 2c8d130
py/stream: Update comment for mp_stream_write_adaptor.
dpgeorge 582b190
py: Add checks for stream objects in print() and sys.print_exception().
dpgeorge b92a8ad
tests: Add tests using "file" argument in print and sys.print_exception.
dpgeorge 34344a4
py/stream: Remove stray empty line at start of file.
dpgeorge 7f41f73
stm32/qspi: Don't require data reads and writes to be a multiple of 4.
dpgeorge ec7982e
stm32/mboot: Add support for erase/read/write of external SPI flash.
dpgeorge 92667dc
tools/pydfu.py: Add support for multiple memory segments.
dpgeorge a2ac7e4
stm32/boards: Add .ld and af.csv files for STM32F722.
dpgeorge c149197
py/compile: Combine break and continue compile functions.
dpgeorge d23bec3
py/compile: Combine subscript_2 and subscript_3 into one function.
dpgeorge 1a7109d
py/compile: Combine global and nonlocal statement compile functions.
dpgeorge 36e474e
py/compile: Combine or_test and and_test compile functions.
dpgeorge 25ae98f
py/compile: Combine expr, xor_expr and and_expr into one function.
dpgeorge 7c21960
WIP: after merge; before testing
dhalbert 0d27f4d
continued WIP: almost compiling
dhalbert e2e01ef
compiles and runs; hangs on import storage;storage.VfsFat.<tab>
dhalbert 2809b4f
Merge branch 'master' into micropython-25ae98f-merge
dhalbert bc760dd
WIP: complete manual inspection of all significant changes
dhalbert f48b700
merge finished
dhalbert 2e260a0
Merge remote-tracking branch 'adafruit/master' into micropython-25ae9…
dhalbert a5068ea
fix .travis.yml
dhalbert bfbb5cd
put back test in qemu-arm build
dhalbert c76a4d4
remove qemu-arm build; fix docs build bugs
dhalbert b100617
Download arm-none toolchain only when necessary.
dhalbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this whole line. This has it always download it when the line above covers the other cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger. Missed that overlap.