shared/supervisor/usb_msc_flash.c: check for valid vfs from get_vfs() #10457
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhalbert Thanks a lot! Just tried it out in the previously problematic configuration and now CIRCUITPY shows up almost immediately again and is writable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SD automount code did not always check for
get_vfs()returningNULLwhen there was no SD card, which caused mysterious results on some boards. On QT Py ESP32-S3, compiled with-Os, 8000 there were issues on Windows. On Feather ESP32-S3, also compiled with-Os, the build simply didn't work.The bug was fixed by adding a check in
tud_msc_capacity_cb(), but checks were added elsewhere for safety as well.@Sola85: I think this should fix what you saw.