8000 Fix terminal on rotation by tannewt · Pull Request #10333 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Fix terminal on rotation #10333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Fix terminal on rotation #10333

merged 1 commit into from
May 9, 2025

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented May 9, 2025

This fixes an issue where a terminal can't be started after being stopped (when tilegrid_tiles is freed and set to NULL.)

Fixes #10241

@tannewt
Fix terminal on rotation
fc540b7 
This fixes an issue where a terminal can't be started after being
stopped (when tilegrid_tiles is freed and set to NULL.)

Fixes micropython#10241
@tannewt tannewt added this to the 10.0.0 milestone May 9, 2025
@tannewt tannewt requested a review from eightycc May 9, 2025 22:15
eightycc
eightycc approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator
@eightycc eightycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Will merge once CI finishes.

@eightycc eightycc merged commit 99d4ea0 into adafruit:main May 9, 2025
540 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eightycc eightycc eightycc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Setting the rotation on a display loses the REPL in 10
2 participants
@tannewt @eightycc
0