8000 Factor out register saves by tannewt · Pull Request #10325 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Factor out register saves #10325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Factor out register saves #10325

merged 2 commits into from
May 9, 2025

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented May 8, 2025

This fixes RISC-V ESP32 because it ignored registers on that architecture.

tannewt added 2 commits May 8, 2025 16:12
@tannewt
Factor out register saves
2bec056 
This fixes RISC-V ESP32 because it ignored registers on that
architecture.
@tannewt
Shrink lolin_c3_mini
e6271b2
@tannewt tannewt marked this pull request as ready for review May 9, 2025 21:24
@tannewt tannewt requested a review from eightycc May 9, 2025 21:24
@tannewt tannewt linked an issue May 9, 2025 that may be closed by this pull request
Add Register Spill to GC for all target processor architectures #10311
Closed
eightycc
eightycc approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator
@eightycc eightycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll approve and merge now.

I'll test the RISC-V case, but I'm confident your changes will work.

@eightycc eightycc merged commit 5ba4f77 into adafruit:main May 9, 2025
16 checks passed
@eightycc
Copy link
Collaborator
eightycc commented May 9, 2025

Testing with an ESP32-C3, it's crashing in the interpreter again.

eightycc added a commit to eightycc/circuitpython that referenced this pull request May 10, 2025
@eightycc
Fix crashing bug in PR adafruit#10325 for RISC-V builds.
739b242
eightycc added a commit to eightycc/circuitpython that referenced this pull request May 10, 2025
@eightycc
Revert PR adafruit#10301, obsoleted by PR adafruit#10325.
1cca691
@eightycc eightycc mentioned this pull request May 10, 2025
Merged
tannewt added a commit that referenced this pull request May 12, 2025
@tannewt
Merge pull request #10337 from eightycc/pr-10325
0893345 
Updates to PR #10325
@dhalbert
Copy link
Collaborator

Is this something to note for the MicroPython folks with an issue?

@eightycc
Copy link
Collaborator
eightycc commented May 13, 2025 •
edited
Loading

Is this something to note for the MicroPython folks with an issue?

I'll look into it while I'm checking #10328.

@dhalbert Verified that MicroPython handles RISC-V properly by unloading its registers before collecting.

@tannewt
Copy link
Member Author
tannewt commented May 13, 2025

Is this something to note for the MicroPython folks with an issue?

They factor out the register collection already here: https://github.com/micropython/micropython/tree/master/shared/runtime in gchelper.

They don't grab pointers out of floating point registers though. (I'm not sure how common it is for a compiler to do that though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eightycc eightycc eightycc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Register Spill to GC for all target processor architectures
3 participants
@tannewt @eightycc @dhalbert
0