8000 Recursive clone of circuitpython fails due to bad submodule path · Issue #2762 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Recursive clone of circuitpython fails due to bad submodule path #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
larsks opened this issue Apr 11, 2020 · 3 comments · Fixed by #2763
Closed

Recursive clone of circuitpython fails due to bad submodule path #2762

larsks opened this issue Apr 11, 2020 · 3 comments · Fixed by #2763

Comments

@larsks
Copy link
larsks commented Apr 11, 2020

The circuitpython repository includes the following submodule:

[submodule "extmod/ulab"]
        path = extmod/ulab
        url = https://github.com/v923z/micropython-ulab/

The trailing slash on the repository URL causes a failure when trying to clone it:

$ git clone https://github.com/v923z/micropython-ulab/
Cloning into 'micropython-ulab'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

This results in a failure when trying to clone circuitpython using git clone --recurse-submodules or when running git submodule update.
@larsks larsks mentioned this issue Apr 11, 2020
Merged
dhalbert pushed a commit that referenced this issue Apr 11, 2020
@larsks
Fix bad submodule path
abf79de 
The repository URL for extmod/ulab had a trailing slash, causing
errors when trying to clone it.

Closes #2762
@jepler
Copy link
jepler commented Apr 11, 2020

I'm curious what git versions were affected by this. Locally I have git version 2.20.1 and did not observe the problem:

$ git clone https://github.com/v923z/micropython-ulab/
Cloning into 'micropython-ulab'...

remote: Enumerating objects: 103, done....

@larsks
Copy link
Author
larsks commented Apr 11, 2020 •
edited
Loading

@jepler Turns out it's not a git version issue, but it's a side effect of my git configuration, which has this:

[url "ssh://git@github.com/"]
        insteadof = https://github.com/

That transforms http:// access into ssh:// access, and while git@github.com:v923z/micropython-ulab is a valid url, git@github.com:v923z/micropython-ulab/ is not.

@jepler
Copy link
jepler commented Apr 11, 2020

Aha, that would do it. I'm glad you were able to diagnose and fix the problem, thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bad submodule path larsks/micropython
2 participants
@larsks @jepler
0