8000 Remove legacy requests.set_socket by justmobilize · Pull Request #2743 · adafruit/Adafruit_Learning_System_Guides · GitHub
[go: up one dir, main page]
Skip to content

Remove legacy requests.set_socket #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sig 8000 n up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

Remove legacy requests.set_socket #2743

merged 1 commit into from
Feb 29, 2024

Conversation

justmobilize
Copy link
Contributor

Remove legacy requests.set_socket and replace with new pool and ssl_context helpers from ConnectionManager

@justmobilize justmobilize marked this pull request as ready for review February 28, 2024 22:17
@TheKitty TheKitty requested review from tannewt and < 8000 a data-hovercard-type="user" data-hovercard-url="/users/dhalbert/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/dhalbert">dhalbert February 28, 2024 22:43
tannewt
tannewt reviewed Feb 29, 2024
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need someone to check all of the corresponding guides and update them too.

@justmobilize
Copy link
Contributor Author

We'll need someone to check all of the corresponding guides and update them too.

@tannewt is this something I can do?

@dhalbert
Copy link
Contributor
dhalbert commented Feb 29, 2024 •
edited
Loading

- Should this wait for adafruit/Adafruit_CircuitPython_MiniMQTT#197 ?

[EDIT: @justmobilize says no]

dhalbert
dhalbert approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks fine. I will look at the corresponding guides.

@dhalbert dhalbert merged commit 85e851d into adafruit:main Feb 29, 2024
@justmobilize justmobilize deleted the remove-set-socket branch February 29, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justmobilize @dhalbert @tannewt
0