Merged
Conversation
Fixed units in docstring. Alternatively, multiple the returned values by 1000 in `_unpack_and_scale` to report microteslas (what all the other magnetic sensors from adafruit report)
Contributor
Author
|
I suppose according to the design guide, changing to microteslas would be better: https://docs.circuitpython.org/en/7.3.x/docs/design_guide.html#sensor-properties-and-units |
Member
|
I'll take a look at this in a couple hours :) |
tekktrik
requested changes
Sep 8, 2022
Member
There was a problem hiding this comment.
Yeah, you're right, per the CircuitPython design guide, let's return this in microtesla. So instead you can change just return binval * 98.0 in _unpack_and_scale() and we can give this a major revision update!
tekktrik
approved these changes
Sep 8, 2022
Member
There was a problem hiding this comment.
Thanks for this, looks good to me!
Contributor
Author
|
thanks @tekktrik ! Also a little self promotion that you or people at adafruit might find interesting (using this and the other adafruit magnetic sensor drivers): |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 9, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_TFmini to 1.2.15 from 1.2.14: > Merge pull request adafruit/Adafruit_CircuitPython_TFmini#14 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 2.0.0 from 1.2.13: > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#16 from BrianPugh/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.16 from 0.5.15: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#28 from tekktrik/dev/fix-ci > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#26 from dedukun/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.3.3 from 5.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_HID#104 from adafruit/typing-improvements > Merge pull request adafruit/Adafruit_CircuitPython_HID#103 from adafruit/dont-crash-on-full > Merge pull request adafruit/Adafruit_CircuitPython_HID#101 from adafruit/fix-import-python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed units in docstring. Alternatively, multiply the returned values by 1000 in
_unpack_and_scaleto report microteslas (what all the other magnetic sensors from adafruit report).