Catch OSError to avoid socket leak#70
Merged
anecdata merged 1 commit intoadafruit:masterfrom Feb 5, 2021
anecdata:outofsockets
Merged
Catch OSError to avoid socket leak#70anecdata merged 1 commit intoadafruit:masterfrom anecdata:outofsockets
anecdata merged 1 commit intoadafruit:masterfrom
anecdata:outofsockets
Conversation
jerryneedell
approved these changes
Feb 4, 2021
Contributor
There was a problem hiding this comment.
Tested on ESP32s2 SAOLA WROVER as part of adafruit/circuitpython#4061
This resolved that issue
Member
Author
brentru
reviewed
Feb 5, 2021
| try: | ||
| self._send_request(socket, host, method, path, headers, data, json) | ||
| except _SendFailed: | ||
| except (_SendFailed, OSError): |
Member
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 9, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.5 from 1.9.4: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#72 from anecdata/recv_into > Merge pull request adafruit/Adafruit_CircuitPython_Requests#70 from anecdata/outofsockets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch
OSErroralong with_SendFailedto avoidRuntimeError: Out of socketscaused byOSError: Failed SSL handshakeBackground:
#63 (comment)
This should address #67