change badgerbase.show to root_group #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 2, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.7.0 from 1.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#21 from FoamyGuy/displayio_9x_compatibility Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#41 from FoamyGuy/9x_compatibility Updating https://github.com/adafruit/Adafruit_CircuitPython_EK79686 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_EK79686#1 from FoamyGuy/root_group_update Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.4.3 from 1.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#22 from tyeth/adjust_setosc Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.4.0 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#19 from FoamyGuy/9x_compatibility Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.1.4 from 2.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#38 from caternuson/mux_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.12 from 1.0.11: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#14 from FoamyGuy/root_group_update Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.2.14 from 1.2.13: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#39 from vin1953/example-url-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.7 from 4.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#91 from DJDevon3/DJDevon3-CMSimpleTest Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.2.10 from 2.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#92 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 4.0.0 from 3.8.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#69 from FoamyGuy/root_group_prop Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 3.2.3 from 3.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#179 from FoamyGuy/remove_pylint_disable > Merge pull request adafruit/Adafruit_CircuitPython_Requests#175 from DJDevon3/DJDevon3-RocketLaunchLive > Merge pull request adafruit/Adafruit_CircuitPython_Requests#174 from DJDevon3/DJDevon3-Youtube Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically this is not required for 9.0.0 because badgerbase.show() was updated internally to use root_group already.
But my assumption is that badgerbase.show() was originally named to match Display.show() so I think it makes sense to change it over to using root_group since that is how Display works now.
It is a breaking change, any code that was using badgerbase.show() would need to update their project code.