8000 Change signature to match builtin by tekktrik · Pull Request #9 · adafruit/Adafruit_CircuitPython_Pixelbuf · GitHub
[go: up one dir, main page]
Skip to content

Change signature to match builtin #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2022
Merged

Change signature to match builtin #9

merged 2 commits into from
Dec 13, 2022

Conversation

tekktrik
Copy link
Member

Fixes #7. While this is API breaking, after checking the libraries and Learn guides, it won't affect them.

@tekktrik tekktrik requested a review from a team December 10, 2022 02:16
askpatrickw
askpatrickw approved these changes Dec 10, 2022
View reviewed changes
Copy link
@askpatrickw askpatrickw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tekktrik tekktrik marked this pull request as draft December 13, 2022 15:47
@tekktrik tekktrik marked this pull request as ready for review December 13, 2022 19:54
@tekktrik tekktrik merged commit 5f64550 into adafruit:main Dec 13, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 14, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@43c5dc5)
08cd27e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Pixelbuf to 2.0.0 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_Pixelbuf#9 from tekktrik/dev/update-signature
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askpatrickw askpatrickw askpatrickw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not the same signature as the builtin version
2 participants
@tekktrik @askpatrickw
0