Optimizations #103
Merged
Optimizations #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a test this improved speed substantially, nearly doubling
the speed of the following test program
```python
pixels = neopixel.NeoPixel(pixel_pin, pixel_num, brightness=1, auto_write=False, pixel_order="RGB")
evens = helper.PixelMap(pixels, [(i,) for i in range(0, pixel_num, 2)], individual_pixels=True)
animation = RainbowChase(evens, 0, spacing=8)
t0 = adafruit_ticks.ticks_ms()
while True:
for i in range(10):
animation.animate(show=False)
t1 = adafruit_ticks.ticks_ms()
print(f"{10000/(t1-t0):.0f}fps")
t0 = t1
```
Performance on Raspberry Pi Pico W:
Before: ~85fps
After: ~140fps
This also happens to make it compatible with an in-process PR that adds
a fast PixelMap-like class to the core, but which doesn't support
getitem.
The big pay-off is avoiding enumerate(). Removing redundant comparisons of _ring() and avoiding modulo operations help too.
FoamyGuy
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
This looks good to me. Thanks for the improvement @jepler.
I tested successfully on a Fun House with neopixel strip (30) with both comet and chase animations. Over 10,000 frames of the chase animation at speed 0.02 it was able to render all the frames about .3 seconds faster (~2.6s current to ~2.3s this branch). Improvements vary by animation type and configuration but have seen some speed increase on all permutations that I tried.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 13, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.1 from 2.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#103 from adafruit/optimizations > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#102 from tekktrik/dev/fix-pylint-errors > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.12.10 from 1.12.9: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#115 from DJDevon3/main > Merge pull request adafruit/Adafruit_CircuitPython_Requests#119 from tekktrik/main > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the speed of the comet and chase (marquee) animations by eliminating expensive operations