8000 Missing Type Annotations · Issue #12 · adafruit/Adafruit_CircuitPython_IterTools · GitHub
[go: up one dir, main page]
Skip to content

Missing Type Annotations #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FoamyGuy op 8000 ened this issue Sep 27, 2021 · 1 comment · Fixed by #25
Closed

Missing Type Annotations #12

FoamyGuy opened this issue Sep 27, 2021 · 1 comment · Fixed by #25
Labels
documentation

Comments

@FoamyGuy
Copy link
Contributor

No description provided.

@FoamyGuy FoamyGuy mentioned this issue Sep 27, 2021
Closed
@FoamyGuy
Copy link
Contributor Author

mypy did not recognize the package in this library due to missing init.py file. See #13 for more info.

Once we resolve #13 I can re-run the type check on this library and I'll edit the original comment above with the results.

@adafruit-adabot adafruit-adabot added the Hacktoberfest DigitalOcean's Hacktoberfest label Oct 26, 2021
@FoamyGuy FoamyGuy removed the Hacktoberfest DigitalOcean's Hacktoberfest label Nov 4, 2021
@adafruit-adabot adafruit-adabot added the Hacktoberfest DigitalOcean's Hacktoberfest label Sep 29, 2022
kbsriram added a commit to kbsriram/Adafruit_CircuitPython_IterTools that referenced this issue Feb 16, 2024
@kbsriram
First batch of type annotations.
11b01d4 
This adds a subset of type annotations for adafruit#12
This PR just adds "simpler" annotations that are hopefully easier
to review in one shot, with follow-up but smaller PRs for some of
the trickier items.
@kbsriram kbsriram mentioned this issue Feb 16, 2024
Merged
kbsriram added a commit to kbsriram/Adafruit_CircuitPython_IterTools that referenced this issue Feb 24, 2024
@kbsriram
Type annotations for adafruit_itertools
b70d9bf 
This adds another set of type annotations for
adafruit#12

- Mypy passes the adafruit_itertools module without errors.
- Added tests for functionality and to exercise type annotations,
  and mypy also passes these tests without errors.
@kbsriram kbsriram mentioned this issue Feb 24, 2024
Merged
@dhalbert dhalbert removed good first issue Good for newcomers Hacktoberfest DigitalOcean's Hacktoberfest labels Mar 25, 2024
kbsriram added a commit to kbsriram/Adafruit_CircuitPython_IterTools that referenced this issue Apr 29, 2024
@kbsriram
Update type annotations for itertools extras.
088e246 
- Fixed a small bug with all_equal() on empty inputs.
- Fixed a documentation bug with pairwise().
- Added tests for all methods.
- Verified mypy --warn-unused-ignores --disallow-untyped-defs runs
  successfully on tests.

Fixes adafruit#12
@kbsriram kbsriram mentioned this issue Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update type annotations for itertools extras. kbsriram/Adafruit_CircuitPython_IterTools
3 participants
@FoamyGuy @dhalbert @adafruit-adabot
0