8000 Don't modify the input `pulses` argument. by Flameeyes · Pull Request #38 · adafruit/Adafruit_CircuitPython_IRRemote · GitHub
[go: up one dir, main page]
Skip to content

Don't modify the input pulses argument. #38

New issue

Have a question about this project? 8000 Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

Don't modify the input pulses argument. #38

merged 1 commit into from
May 26, 2020

Conversation

Flameeyes
Copy link
Contributor

Instead of deleting header and trailer, just skip them when dividing the
pulses in evens and odds.

@Flameeyes
Don't modify the input pulses argument.
1820bf7 
Instead of deleting header and trailer, just skip them when dividing the
pulses in evens and odds.
dhalbert
dhalbert approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Modifying the incoming argument is a pretty bad idea, especially if you called this multiple times.

@dhalbert dhalbert merged commit deda3af into adafruit:master May 26, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 27, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@5cb9ec6)
d2a7531 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.0.0 from 3.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#38 from Flameeyes/fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.2.0 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#12 from jimbobbennett/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_ICM20X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flameeyes @dhalbert
0