8000 correct Missing Type Annotations #6 by tcfranks · Pull Request #8 · adafruit/Adafruit_CircuitPython_FakeRequests · GitHub
[go: up one dir, main page]
Skip to content

correct Missing Type Annotations #6 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2022
Merged

correct Missing Type Annotations #6 #8

merged 2 commits into from
Aug 19, 2022

Conversation

tcfranks
Copy link
Contributor

No description provided.

@tcfranks
Copy link
Contributor Author

corrections / learning anticipated.....

@tekktrik tekktrik self-requested a review August 19, 2022 15:50
@tekktrik tekktrik self-assigned this Aug 19, 2022
@tekktrik tekktrik requested review from a team and removed request for tekktrik August 19, 2022 15:52
tekktrik
tekktrik requested changes Aug 19, 2022
View reviewed changes
Copy link
Member
@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, but looks great otherwise!

tekktrik
tekktrik approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member
@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tekktrik tekktrik merged commit 9e9e8b7 into adafruit:main Aug 19, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 20, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@70cf49e)
740c5aa 
Updating https://github.com/adafruit/Adafruit_CircuitPython_FakeRequests to 1.0.10 from 1.0.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_FakeRequests#8 from tcfranks/main
  > Fix version strings in workflow files
  > Update version string

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 0.5.0 from 0.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#12 from eirinnm/main
  > Fix version strings in workflow files
  > Update version string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees

@tekktrik tekktrik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcfranks @tekktrik
0