Compability with Rails's main branch (7.0.0.alpha) #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the tests are failing because:
so I "downgraded" rails locally to 6.1.3 |
|
ok, removed the upgrades because it's failing on jruby, will do a separate PR |
sunny
reviewed
Dec 16, 2021
| @@ -21,6 +21,6 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.required_ruby_version = '>= 2.5' | |||
|
|
|||
| s.add_dependency("activesupport", ">= 3.0.0", "< 6.2") | |||
| s.add_dependency("activesupport", ">= 3.0.0", "< 7.0") | |||
There was a problem hiding this comment.
Now that Rails 7 is released, this should probably be changed to:
Suggested change
| s.add_dependency("activesupport", ">= 3.0.0", "< 7.0") | |
| s.add_dependency("activesupport", ">= 3.0.0", "< 8.0") |
|
The |
Closed
|
We'll tackle this in #314 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the tests and everything is green.
I updated the rails version used in the local Gemfile to the latest commit on rails/rails main branch.
I figured if you want to test against different versions of rails you could use appraisal https://github.com/thoughtbot/appraisal
Really not sure about my approach, let me know what you think ❤️