8000 Add some :uk locales by ishe-ua · Pull Request #8732 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]

Skip to content

Add some :uk locales #8732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

Add some :uk locales #8732

merged 3 commits into from
May 30, 2025

Conversation

ishe-ua
Copy link
Contributor
@ishe-ua ishe-ua commented May 29, 2025

For version 4.

Copy link
codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (3976a37) to head (395d833).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8732   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4074     4074           
=======================================
  Hits         4038     4038           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tagliala tagliala requested a review from Copilot May 29, 2025 13:52
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Ukrainian (:uk) locale translations for various UI toggles and ActiveRecord models/attributes to support version 4.

  • Introduces toggle labels for dark mode, navigation, sections, and user menu
  • Adds ActiveRecord attribute translations for comments
  • Provides pluralization keys for active_admin/comment and comment models

@tagliala
Copy link
Contributor

@ishe-ua thanks for this PR. Could you please check if Copilot has valid points and answer its comments?

Thank you, Copilot!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ishe-ua
Copy link
Contributor Author
ishe-ua commented May 29, 2025

@ishe-ua thanks for this PR. Could you please check if Copilot has valid points and answer its comments?

done

@ishe-ua ishe-ua closed this May 30, 2025
@ishe-ua ishe-ua reopened this May 30, 2025
@tagliala tagliala requested a review from Copilot May 30, 2025 07:29
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new UK locale translations to support version 4 of the project.

  • Introduces new keys such as created_at, delete, and delete_confirmation in the main locales file.
  • Adds additional translation entries for dashboard, pagination, and activerecord settings.

@tagliala tagliala merged commit 8a47c2c into activeadmin:master May 30, 2025
26 checks passed
@tagliala
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0