8000 Normalize i18n locale files by tagliala · Pull Request #8715 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]

Skip to content

Normalize i18n locale files #8715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Normalize i18n locale files #8715

merged 1 commit into from
May 7, 2025

Conversation

tagliala
Copy link
Contributor
@tagliala tagliala commented May 6, 2025

This commit applies i18n-tasks normalize to automatically reorder,
format, and clean up locale files. The changes ensure consistency across
translations and align them with the structure recommended by
i18n-tasks health.

  • Improves maintainability of locale files by normalizing keys.
  • Reduces potential errors caused by inconsistent translation
    structures.
  • Prepares locale files for easier future updates and auditing.
  • Adds a spec to ensure that unnormalized translations cannot be added
    to the project.

The normalization process is a step towards compliance with best
practices for internationalization, making it easier to manage
translations across the project.

@tagliala tagliala marked this pull request as draft May 6, 2025 21:15
@tagliala tagliala force-pushed the chore/better-i18n-specs branch from c2d0678 to 24d0941 Compare May 6, 2025 21:20
@tagliala tagliala changed the title Add normalize check to i18n-specs Normalize i18n locale files May 6, 2025
This commit applies `i18n-tasks normalize` to automatically reorder,
format, and clean up locale files. The changes ensure consistency across
translations and align them with the structure recommended by
`i18n-tasks health`.

- Improves maintainability of locale files by normalizing keys.
- Reduces potential errors caused by inconsistent translation
  structures.
- Prepares locale files for easier future updates and auditing.
- Adds a spec to ensure that unnormalized translations cannot be added
  to the project.


The normalization process is a step towards compliance with best
practices for internationalization, making it easier to manage
translations across the project.
@tagliala tagliala force-pushed the chore/better-i18n-specs branch from 24d0941 to c792afc Compare May 6, 2025 21:28
Copy link
codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (1de7028) to head (c792afc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8715   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4074     4074           
=======================================
  Hits         4038     4038           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tagliala tagliala requested a review from javierjulio May 6, 2025 21:34
@tagliala tagliala marked this pull request as ready for review May 6, 2025 21:44
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 801a768 into master May 7, 2025
29 checks passed
@tagliala tagliala deleted the chore/better-i18n-specs branch May 7, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0