-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix typo in batch_actions locale translation key #8712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cde0e4b
to
fc272e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8712 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4076 4076
=======================================
Hits 4040 4040
Misses 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tagliala thank you. We just need to update the locale section in the Upgrading guide to call out this typo correction.
a3a51f6
to
1f21c6d
Compare
Thanks. Guide updated & force-pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tagliala thanks. I've added the typos workflow in #8713 so if you rebase here it will now run. You'll need to include the following updates.
Please delete this line since it's was temporary to get #8713 to pass:
Line 4 in 0ef1d6a
"succesfully_destroyed" |
Please add the following before the [files]
line, to ignore the typo in the Upgrading guide:
[type.md]
extend-exclude = [
"!UPGRADING.md"
]
extend-ignore-identifiers-re = [
"succesfully_destroyed"
]
If you'd like to run the CLI locally, run brew install typos-cli
and then typos
at the root level (no arguments needed).
1f21c6d
to
d15448d
Compare
This may be considered a breaking change, and the upgrading guide has been updated accordingly Close #8711
d15448d
to
876ed27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Close #8711