8000 Fix typo in batch_actions locale translation key by tagliala · Pull Request #8712 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]

Skip to content

Fix typo in batch_actions locale translation key #8712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

tagliala
Copy link
Contributor
@tagliala tagliala commented May 6, 2025

Close #8711

Copy link
codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (0ef1d6a) to head (876ed27).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8712   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagliala thank you. We just need to update the locale section in the Upgrading guide to call out this typo correction.

@tagliala tagliala force-pushed the chore/8711-translation-key branch 2 times, most recently from a3a51f6 to 1f21c6d Compare May 6, 2025 14:18
@tagliala
Copy link
Contributor Author
tagliala commented May 6, 2025

Thanks. Guide updated & force-pushed

@tagliala tagliala requested a review from javierjulio May 6, 2025 14:34
@javierjulio javierjulio mentioned this pull request May 6, 2025
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagliala thanks. I've added the typos workflow in #8713 so if you rebase here it will now run. You'll need to include the following updates.

Please delete this line since it's was temporary to get #8713 to pass:

"succesfully_destroyed"

Please add the following before the [files] line, to ignore the typo in the Upgrading guide:

[type.md]
extend-exclude = [
  "!UPGRADING.md"
]
extend-ignore-identifiers-re = [
  "succesfully_destroyed"
]

If you'd like to run the CLI locally, run brew install typos-cli and then typos at the root level (no arguments needed).

@tagliala tagliala force-pushed the chore/8711-translation-key branch from 1f21c6d to d15448d Compare May 6, 2025 15:08
This may be considered a breaking change, and the upgrading guide
has been updated accordingly

Close #8711
@tagliala tagliala force-pushed the chore/8711-translation-key branch from d15448d to 876ed27 Compare May 6, 2025 15:39
@javierjulio javierjulio changed the title Fix typo in translation key Fix typo in batch_actions translation key May 6, 2025
@javierjulio javierjulio changed the title Fix typo in batch_actions translation key Fix typo in batch_actions locale translation key May 6, 2025
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 9d73b20 into master May 6, 2025
30 checks passed
@tagliala tagliala deleted the chore/8711-translation-key branch May 6, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation key misspelling: "succesfully_destroyed" missing an "s"
2 participants
0