8000 Bump tailwind from 3.4.17 to 4.1.11 by tagliala · Pull Request #8709 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Bump tailwind from 3.4.17 to 4.1.11 #8709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bump tailwind from 3.4.17 to 4.1.11 #8709

wants to merge 4 commits into from
+84 −608

Conversation

tagliala
Copy link
Contributor
@tagliala tagliala commented May 5, 2025 •
edited
Loading
  • Remove tailwind v3 downgrade from test-application
  • Use tailwind cli to compile css
  • Delete generated files that are not used
  • Add a reference to old javascript config file
  • Remove @tailwind directive
  • Remove config argument when adding build:css script to test app
  • Rename deprecated utilities https://tailwindcss.com/docs/upgrade-guide#renamed-utilities

TODO:

  • https://tailwindcss.com/docs/upgrade-guide#default-border-color
    image
  • Warning in console 
    15:46:31 css.1     | (node:70995) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///.../tailwind-active_admin.config.js?id=1746452791729 is not specified and it doesn't parse as CommonJS.
15:46:31 css.1     | Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
15:46:31 css.1     | To eliminate this warning, add "type": "module" to ./package.json.
15:46:31 css.1     | (Use `node --trace-warnings ...` to show where the warning was created)
    Document to add "type": "module", to app's package.json ? 3bfb95e#r1972531187
  • tailwindcss@cli should be installed as a dev dependency? Not from scratch, this is being done by cssbundling rails 
    15:49:56 css.1     | Need to install the following packages:
15:49:56 css.1     | @tailwindcss/cli@4.1.5

Additionally:

  • Set scheme-dark on input fields when dark mode is enabled

    Before

    image

    After

    image

@codecov Codecov
Copy link
codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (c5943e9) to head (ecfd8a2).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8709   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4074     4074           
=======================================
  Hits         4038     4038           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
8000

@tagliala tagliala mentioned this pull request May 5, 2025
Closed
tagliala
tagliala commented May 5, 2025
View reviewed changes
UPGRADING.md
Copy link
Contributor Author
@tagliala tagliala May 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/activeadmin/activeadmin/blob/tagliala/tailwind-v4/UPGRADING.md#upgrading-from-earlier-4x-beta-to-400beta16

@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch from 11c4e9e to 4d2b2d1 Compare May 5, 2025 19:17
@tagliala tagliala requested a review from javierjulio May 5, 2025 20:19
@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch 4 times, most recently from 5e6685d to 99c9780 Compare May 7, 2025 07:40
@tagliala tagliala removed the request for review from javierjulio May 7, 2025 07:42
@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch 5 times, most recently from e8154c9 to 7b44d57 Compare May 8, 2025 07:40
@tagliala tagliala requested review from javierjulio and mgrunberg May 8, 2025 08:17
@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch 2 times, most recently from 16a5e61 to 2916f72 Compare May 11, 2025 20:16
@tagliala tagliala changed the title Bump tailwind from 3.4.17 to 4.1.5 Bump tailwind from 3.4.17 to 4.1.6 May 11, 2025
@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch from 2916f72 to e131141 Compare May 15, 2025 15:47
@tagliala tagliala changed the title Bump tailwind from 3.4.17 to 4.1.6 Bump tailwind from 3.4.17 to 4.1.7 May 15, 2025
rajputlakhveer
rajputlakhveer approved these changes May 17, 2025
View reviewed changes
Copy link
@rajputlakhveer rajputlakhveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Tested! Worked for me.

@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch from e131141 to 5bf67d5 Compare May 31, 2025 07:34
@tagliala tagliala changed the title Bump tailwind from 3.4.17 to 4.1.7 Bump tailwind from 3.4.17 to 4.1.8 Jun 1, 2025
@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch from 5bf67d5 to 92fd144 Compare June 12, 2025 10:57
@tagliala tagliala changed the title Bump tailwind from 3.4.17 to 4.1.8 Bump tailwind from 3.4.17 to 4.1.10 Jun 12, 2025
@bopm
Copy link
bopm commented Jun 16, 2025

@tagliala I would like to bring this to your attention, and happy to help you adopt it in this PR.

@tagliala
Copy link
Contributor Author

@tagliala I would like to bring this to your attention, and happy to help you adopt it in this PR.

Hello, thanks for the heads up

From the documentation and from your comment at rails/tailwindcss-rails#554 (comment)

I understand that

You need to @import those files into your main Tailwind application.css

It looks like it is mandatory to import in 8000 the main application.css, which is not what we want here (css files should be separated, we don't want to mix activeadmin and application styles: application may not even use tailwind)

At the moment, activeadmin does not even use tailwindcss-rails and I'm not in the position to make this change, but it would be interesting to see how this new feature can help here. Can you fork and make the changes on top of this branch, so I can take a look?

@bopm
Copy link
bopm commented Jun 17, 2025

That is what I am looking for: specific scenarios to trial this experimental approach. Let me think a bit, I'll get back to you.

mgrunberg and others added 4 commits June 27, 2025 09:32
@mgrunberg @tagliala
Bump tailwind from 3.4.17 to 4.1.11
f9c44a3 
- Remove tailwind v3 downgrade from test-application
- Use tailwind cli to compile css
- Delete generated files that are not used
- Add a reference to old javascript config file
- Remove `@tailwind` directive
- Remove config argument when adding `build:css` script to test app
- Rename deprecated utilities
  https://tailwindcss.com/docs/upgrade-guide#renamed-utilities
@tagliala
Add missing border colors for v4
cf5af19 
https://tailwindcss.com/docs/upgrade-guide#default-border-color
@tagliala
Set color-scheme on input fields
fbb71f8 
Use v4's `scheme-dark` to fix icon colors on some native inputs

Ref: https://v3.tailwindcss.com/docs/v4-beta#color-scheme-utilities
@tagliala
Update upgrading guide
ecfd8a2
@tagliala tagliala force-pushed the tagliala/tailwind-v4 branch from 92fd144 to ecfd8a2 Compare June 27, 2025 07:34
@tagliala tagliala changed the title Bump tailwind from 3.4.17 to 4.1.10 Bump tailwind from 3.4.17 to 4.1.11 Jun 27, 2025
@jeremybdk
Copy link

I know there are still discussions over that PR, but it would be nice to have a first iteration of the support merged so we can use it with apps with tailwind v4... Can we help achieve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrunberg mgrunberg mgrunberg approved these changes

@rajputlakhveer rajputlakhveer rajputlakhveer approved these changes

@javierjulio javierjulio Awaiting requested review from javierjulio

Assignees
No one assigned
Labels
type breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tagliala @bopm @jeremybdk @mgrunberg @rajputlakhveer
0