8000 Adds padding to button unordered lists by natewallis · Pull Request #8680 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Adds padding to button unordered lists #8680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adds padding to button unordered lists #8680

wants to merge 1 commit into from

Conversation

natewallis
Copy link

This tiny PR adds some padding to the unordered lists that represent a buttons children.

Having recently upgraded to the latest version, I noticed that when there is a large amount of items in the left hand navigation it becomes hard to get a visual lock on which item on the left hand menu is selected. Without rewriting all the colors you use, I think this small padding tweak gets around the majority of the issue.

Before:

image

After:

image

@tagliala
Copy link
Contributor
tagliala commented Apr 8, 2025

Hello,

thanks for this PR

IIRC it is a choice to have all the entries without padding, but let's keep this open for review

Refers to: #8225

@tagliala tagliala requested a review from javierjulio April 8, 2025 08:51
@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (a8b1024) to head (02092cc).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8680   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@natewallis
Copy link
Author
natewallis commented Apr 8, 2025 •
edited
Loading
9EC0

Hello,

thanks for this PR

IIRC it is a choice to have all the entries without padding, but let's keep this open for review

Refers to: #8225

Thanks, TBH I am relatively new to activeadmin, my understanding was the padding I was adjusting in my PR was for the new BETA UI with the side navigation, the PR you are referencing seems older, would that be for the previous release UI with the navigation across the top of the screen?

@javierjulio
Copy link
Member

@natewallis thank you. This was intentional as the partials are meant to be customized to suit your needs. The preference is to keep this minimal for that case. The linked PR is related. If we want to apply some more styling, we'll address it there once we get to it.

@javierjulio javierjulio closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio Awaiting requested review from javierjulio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natewallis @tagliala @javierjulio
0