-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Upgrade vendored jQuery UI to 1.14.1 [Pending upstream release] #8670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e035144
to
5e4e6c8
Compare
JavaScript files have been manually updated because: - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork of `jquery-ui-rails` is bundling 1.13.2, but there is a more recent version (1.13.3) Files removed because they have been dropped from jQuery UI: - form.js - ie.js - safe-active-element.js - safe-blur.js Refs: - #8656 - https://jqueryui.com/upgrade-guide/1.14/#removed-apis
5e4e6c8
to
e98b191
Compare
@tobischo despite the tab component seems to work at http://localhost:3000/admin/kitchensink, there is a legit failure in cucumber specs
I will keep investigating, but if you know the reason feel free to provide information on how to fix |
This is actually an issue with activeadmin and should be related to #8616
Actually GitHub does the same for wiki pages, and the behavior works Reproducible test case: |
Reported here: jquery/jquery-ui#2344 |
Admittedly, this is part of the tests I didn't run before, since it got properly triggered only when I created a PR onto my own repo as well earlier today. We are not using tabs, so it didn't effect the "production test" for us. |
Acknowledged as an issue, waiting for 1.14.2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8670 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4971
Branches ? 0
=============================================
Hits ? 4931
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm going to close here for the moment. I will reopen when 1.14.2 will be released. The effort of downgrading to 1.14.0 and adding rules to package.json is not worth it, because there are other solutions (use I suggest to fork and use this branch on a fork, because I may force push here or delete the branch |
JavaScript files have been manually updated because:
jquery-ui-rails
is unmaintained and it is bundling 1.13.0jquery-ui-rails
is bundling 1.13.2, but there is a more recent version (1.13.3)Files removed because they have been dropped from jQuery UI:
Refs:
Manual tests checklist: