8000 Backport Fix deprecation warning in Ruby 3.4 (#8593) by tagliala · Pull Request #8596 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Backport Fix deprecation warning in Ruby 3.4 (#8593) #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

Backport Fix deprecation warning in Ruby 3.4 (#8593) #8596

merged 1 commit into from
Jan 4, 2025

Conversation

tagliala
Copy link
Contributor
@tagliala tagliala commented Jan 4, 2025

No description provided.

@tagliala tagliala linked an issue Jan 4, 2025 that may be closed by this pull request
Backport #8593 to 3-0-stable #8595
Closed
@tagliala tagliala changed the title Fix deprecation warning in Ruby 3.4 (#8593) [3.x] Fix deprecation warning in Ruby 3.4 (#8593) Jan 4, 2025
@codecov Codecov
Copy link
codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3-0-stable@d870d54). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff              @@
##             3-0-stable    #8596   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4963           
  Branches              ?        0           
=============================================
  Hits                  ?     4923           
  Misses                ?       40           
  Partials              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@javierjulio javierjulio self-requested a review January 4, 2025 20:41
javierjulio
javierjulio approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javierjulio javierjulio changed the title [3.x] Fix deprecation warning in Ruby 3.4 (#8593) Backport Fix deprecation warning in Ruby 3.4 (#8593) Jan 4, 2025
@ybart @tagliala
Fix deprecation warning in Ruby 3.4 (#8593)
902a622 
After upgrade to Ruby 3.4, our test suite outputs the following warning:

```
lib/active_admin/inputs/filters/select_input.rb:19: warning: string returned by <Symbol>.to_s will be frozen in the future
```
@tagliala tagliala force-pushed the chore/8595-backport-8593 branch from cfae84e to 902a622 Compare January 4, 2025 20:48
@tagliala tagliala merged commit c0749f5 into 3-0-stable Jan 4, 2025
21 checks passed
@tagliala tagliala deleted the chore/8595-backport-8593 branch January 4, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
type bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backport #8593 to 3-0-stable
4 participants
@tagliala @javierjulio @mgrunberg @ybart
0