10000 (Backport) Fix attributes passed to form has_many not being set on new record form items by Fs00 · Pull Request #8551 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

(Backport) Fix attributes passed to form has_many not being set on new record form items #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

(Backport) Fix attributes passed to form has_many not being set on new record form items #8551

merged 1 commit into from
Nov 25, 2024

Conversation

Fs00
Copy link
Contributor
@Fs00 Fs00 commented Nov 21, 2024

Backports #8550 for ActiveAdmin 3.x.

The diff is basically the same except for CSS classes that differ between AA 3 and 4.

@Fs00 Fs00 mentioned this pull request Nov 21, 2024
Merged
@codecov Codecov
Copy link
codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3-0-stable@f5fff24). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff              @@
##             3-0-stable    #8551   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4965           
  Branches              ?        0           
=============================================
  Hits                  ?     4925           
  Misses                ?       40           
  Partials              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@javierjulio javierjulio self-assigned this Nov 25, 2024
@javierjulio javierjulio self-requested a review November 25, 2024 20:50
javierjulio
javierjulio approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javierjulio javierjulio merged commit 856cfd4 into activeadmin:3-0-stable Nov 25, 2024
19 checks passed
@Fs00
Copy link
Contributor Author
Fs00 commented Mar 7, 2025

Would it be possible to get a new 3.x patch release with this change once #8650 is merged? This change would really be useful to us.
It's already available in 4.0 beta releases since a while, but unfortunately we won't be able to upgrade in the near future.

@mgrunberg
Copy link
Contributor

Would it be possible to get a new 3.x patch release with this change once #8650 is merged? This change would really be useful to us. It's already available in 4.0 beta releases since a while, but unfortunately we won't be able to upgrade in the near future.

@Fs00 A new v3 version is gonna be released in the following days. The plan is to merge that PR and another one, then cut a new release.

@Fs00
Copy link
Contributor Author
Fs00 commented Mar 7, 2025

This is great news, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees

@javierjulio javierjulio

Labels
type bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fs00 @mgrunberg @javierjulio
0