Remove redundant safe navigation operator #8528
Conversation
| @@ -24,7 +24,7 @@ def DISPLAY_NAME_FALLBACK.inspect | |||
| def display_name(resource) | |||
| unless resource.nil? | |||
| result = render_in_context(resource, display_name_method_for(resource)) | |||
| if result.to_s&.strip&.present? | |||
| if result.to_s.strip.present? | |||
There was a problem hiding this comment.
unless I'm missing something and in some circumstances to_s can be nil (maybe override to_s, but that is a user problem)
It may happen in AR when you do something like
class MyModel < ApplicationRecord
def to_s
name
end
endand name is nil.
But this should not be expected and is hiding a problem
This should be implemented with delegate :to_s, to: :name
Feel free to reject this change
There was a problem hiding this comment.
I made this update in #6342 but I don't recall why I used the safe navigation operator. Likely just out of caution without really knowing that nil.to_s will return an empty string so it is redundant as you say. This looks good to me and makes sense to change. Thank you.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8528 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4076 4076
=======================================
Hits 4040 4040
Misses 36 36 ☔ View full report in Codecov by Sentry. |
cbd105e to
0594538
Compare
Remove redundant safe navigation operator (`&.`) in `result.to_s.strip.present?` check, as `to_s` handles `nil` gracefully by converting it to an empty string. This makes the code cleaner and more idiomatic without altering behavior. Ref: https://ruby-doc.org/core-3.1.0/Object.html#method-i-to_s
0594538 to
e49f86e
Compare
Remove redundant safe navigation operator (
&.) inresult.to_s.strip.present?check, asto_shandlesnilgracefully by converting it to an empty string.This makes the code cleaner and more idiomatic without altering behavior.
Ref: https://ruby-doc.org/core-3.1.0/Object.html#method-i-to_s