8000 Update zh-TW & ja locale with new v4 keys by hohayo · Pull Request #8521 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Update zh-TW & ja locale with new v4 keys #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

Update zh-TW & ja locale with new v4 keys #8521

merged 2 commits into from
Oct 31, 2024

Conversation

hohayo
Copy link
Contributor
@hohayo hohayo commented Oct 31, 2024

Add translation for toggle menu

update_toggle_menu_translation

tagliala
tagliala reviewed Oct 31, 2024
View reviewed changes
tagliala
tagliala requested changes Oct 31, 2024
View reviewed changes
@hohayo hohayo requested a review from tagliala October 31, 2024 15:31
tagliala
tagliala requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor
@tagliala tagliala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

please remove changes from en.yml

@hohayo hohayo requested a review from tagliala October 31, 2024 15:37
@codecov Codecov
Copy link
codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (210344a) to head (ae9d8df).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8521   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hohayo hohayo changed the title Update zh-TW locale with new v4 keys Update zh-TW & ja locale with new v4 keys Oct 31, 2024
@tagliala tagliala merged commit 00291b0 into activeadmin:master Oct 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tagliala tagliala tagliala approved these changes

Assignees
No one assigned
Labels
type enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hohayo @tagliala @javierjulio
0