8000 perform_database_query_matcher should be truthy as long as one query matches by mgrunberg · Pull Request #8471 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

perform_database_query_matcher should be truthy as long as one query matches #8471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

perform_database_query_matcher should be truthy as long as one query matches #8471

merged 2 commits into from
Sep 4, 2024

Conversation

mgrunberg
Copy link
Contributor

Found while working in #8470

Before this commit the order or SQL queries matter:

  • match, not match

results in a false matching when it should be true

@mgrunberg
perform_database_query_matcher should be truthy as long as one query
f459204 
matches

Before this commit the order or SQL queries matter:

- match, not match

results in a false matching when it should be true
@codecov Codecov
Copy link
codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (7117d59) to head (8185309).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8471   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4069     4069           
=======================================
  Hits         4033     4033           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

javierjulio
javierjulio reviewed Sep 4, 2024
View reviewed changes
@mgrunberg @javierjulio
Update spec/support/matchers/perform_database_query_matcher.rb
8185309 
Co-authored-by: Javier Julio <JJfutbol@gmail.com>
@mgrunberg mgrunberg merged commit 1477e90 into master Sep 4, 2024
25 checks passed
@mgrunberg mgrunberg deleted the fix-perform_database_query_matcher branch September 4, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio left review comments

Assignees
No one assigned
Labels
type bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgrunberg @javierjulio
0