Move theme setup script into a partial #8462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the logic to intialize the them "private". Users don't need to know the JS we use when they install views. Simplify the update process for users if we ever make any change to that.
tagliala
reviewed
Aug 30, 2024
| @@ -0,0 +1,8 @@ | |||
| <% # On page load or when changing themes, best to add inline in `head` to avoid FOUC %> | |||
| <%= javascript_tag nonce: true do %> | |||
| if (localStorage.theme === 'dark' || (!('theme' in localStorage) && window.matchMedia('(prefers-color-scheme: dark)').matches)) { | |||
There was a problem hiding this comment.
Should theme be prefixed by activeAdmin or configurable?
I understand that in some circumstances it is better to use the same application theme, but changing the theme in the admin area should not affect the application and vice versa 🤔
/cc @javierjulio
|
@tagliala I don't have an answer for your question but it made me change my mind. I'm not sure anymore that this PR is a good move. Now it seems a premature optimization. I'm closing the PR, you or Javier are open to re-open it (or create a new one. I don't know our policy here 😅) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the logic to intialize the them "private".
Users don't need to know the JS we use when they install views.
Simplify the update process for users if we ever make any change to
that.