Use attribute_types instead of columns_hash to determine type #8457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8457 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4069 4069
=======================================
Hits 4033 4033
Misses 36 36 ☔ View full report in Codecov by Sentry. |
javierjulio
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thanks! @tagliala @mgrunberg any concerns with this change? I've used the Attributes API before and makes sense to me. I figured I'd see if either of you know more before merging.
|
@javierjulio no concerns here, LGTM. |
Previously, virtual attributes of type boolean with value `nil` would not be rendered as status tag. This also improves boolean detection in rare cases when an `attribute` declaration overrides the type detected in the database.
4cf9117 to
e3fe8d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, virtual attributes of type boolean with value
nilwould not be rendered as status tag. This also improves boolean detection in rare cases when anattributedeclaration overrides the type detected in the database.attribute_typesexisted already in Rails 6.1, so it should be safe to use.