8000 Use consistent text-like inputs selector list for CSS styles by til · Pull Request #8456 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Use consistent text-like inputs selector list for CSS styles #8456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

Use consistent text-like inputs selector list for CSS styles #8456

merged 1 commit into from
Aug 28, 2024

Conversation

til
Copy link
Contributor
@til til commented Aug 25, 2024

Previously, inputs with type=datetime-local, type=search, type=week and type=month were missing some tailwind styles.

Before:
screenshot-20240825-125818

After:
screenshot-20240825-125752

@til til force-pushed the fix-form-inputs-styling branch from b8a997e to aa673e4 Compare August 25, 2024 12:39
@codecov Codecov
Copy link
codecov bot commented Aug 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (2a1c71b) to head (62d3dfa).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8456   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4069     4069           
=======================================
  Hits         4033     4033           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

javierjulio
javierjulio reviewed Aug 26, 2024
View reviewed changes
@til til force-pushed the fix-form-inputs-styling branch from aa673e4 to adcf0c2 Compare August 26, 2024 21:18
@til til requested a review from javierjulio August 26, 2024 21:20
@til
Copy link
Contributor Author
til commented Aug 26, 2024

Force-pushed to only append the missing types to the selector, leaving all styles in place.

javierjulio
javierjulio approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@til @javierjulio
Use consistent list of text-like inputs for styling
62d3dfa 
Previously, inputs with type=datetime-local, type=search, type=week
and type=month were missing some tailwind styles.
@javierjulio javierjulio force-pushed the fix-form-inputs-styling branch from adcf0c2 to 62d3dfa Compare August 28, 2024 15:50
@javierjulio javierjulio changed the title Use consistent list of text-like inputs for styling Use consistent text-like inputs list for CSS styles Aug 28, 2024
@javierjulio javierjulio changed the title Use consistent text-like inputs list for CSS styles Use consistent text-like inputs selector list for CSS styles Aug 28, 2024
@javierjulio javierjulio merged commit 72b8252 into activeadmin:master Aug 28, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
type bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@til @javierjulio
0