8000 Update bug report template to Rails 7.2 by tagliala · Pull Request #8451 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]

Skip to content

Update bug report template to Rails 7.2 #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tagliala
Copy link
Contributor

Also set config.eager_load to avoid a warning on stdout:

config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly:

Copy link
codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (858f6b3) to head (d9dc4a7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8451   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4066     4066           
=======================================
  Hits         4030     4030           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio self-requested a review August 23, 2024 20:40
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala force-pushed the chore/update-bug-report-template branch from 0f5e05e to f088d0c Compare August 24, 2024 06:19
Also set config.eager_load to avoid a warning on stdout:

```
config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly:
```
@tagliala tagliala force-pushed the chore/update-bug-report-template branch from f088d0c to d9dc4a7 Compare August 24, 2024 06:34
@tagliala tagliala merged commit df64a45 into activeadmin:master Aug 24, 2024
24 checks passed
@tagliala tagliala deleted the chore/update-bug-report-template branch August 24, 2024 06:42
tagliala added a commit that referenced this pull request Aug 24, 2024
* Update dependencies

Relax sqlite3 version constraint because rails/rails#51636 is included
in the latest 7.1.4 release

* Fix bug report template and update to Rails 7.2

Current bug report template does not work because sqlite3 2.x is not
compatible with Rails 7.0.x.

This commit also:
- Test bug report template against Ruby 3.3
- Set config.eager_load to avoid a warning on stdout:
  ```
  config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly:
  ```
- Default to `3-0-stable` branch when `ACTIVE_ADMIN_PATH` is not
  specified
- Add `force_ruby_platform` to `sqlite3` for uniformity with `master`
  branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0