Drop support for Rails 6.1 #8449
Conversation
99f1c1c to
94d5f3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8449 +/- ##
==========================================
- Coverage 99.11% 99.11% -0.01%
==========================================
Files 141 141
Lines 4069 4064 -5
==========================================
- Hits 4033 4028 -5
Misses 36 36 ☔ View full report in Codecov by Sentry. |
369810c to
c27d8b0
Compare
|
@javierjulio, @tagliala is it too premature to do this now? Considering we are working on a major release. |
|
@mgrunberg no, I don't think so. We can leave this open until we are ready to merge. The Rails maintenance page states that 6.1 is supported through October 1, 2024 for security releases only. |
da07c11 to
70c3438
Compare
|
Maybe this is a good time to ,erge Since there are required workflows to pass
We can either remove those or bypass the rule for this PR |
|
When we approve this, we'll remove those required status checks first before merging since they won't apply anymore. Since we are coming up on the date next week, I think it's fine to get ready to merge whenever. Thank you. |
|
@tagliala I didn't realize that was an option in rubocop-rails but makes sense and it is supported as I see mentions in the docs, thank you. Feel free to add it here if you like Matias. |
|
I added the TargetRubyVersion. Thank @tagliala for the suggestion. @javierjulio are we good to merge the PR now? |
According to Rails Maintenance Policy, Rails 6.1 is about to loose security update in a month more or less and reach EOL (check here).
We can keep support for Rails 6.1 as long as we want.
The PR is to track the required changes to drop support