Be able to customize Tag resource form #8448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#8439 improved form attributes rendering but introduced an issue if host app has an admin for Tag resource. The problem is that `tag` (`tag.attributes`) refences the resource and not the `TagHelper`. Let's prefix the call with `helpers`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8448 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4064 4066 +2
=======================================
+ Hits 4028 4030 +2
Misses 36 36 ☔ View full report in Codecov by Sentry. |
|
Apologies and thank you! |
|
@amiel not your fault and no need to apologize. This has happened before with Arbre so not surprising. @mgrunberg thank you again for addressing in both version tracks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8439 improved form attributes rendering but introduced an issue if host app has an admin for Tag resource.
The following code (generated by our template app) raise errors
# admin/tags.rb ActiveAdmin.register Tag do form do |f| f.inputs "Details" do f.input :name end f.actions end endThe problem is that
tag(tag.attributes) evaluates to the resource and not theTagHelper.The default form works because it's rendered in a different scope (view context?).
The problem surfaced during backport development: #8446.
Let's prefix the call with
helpers.