8000 Update changelog_uri in gemspec metadata to GitHub Releases by mattbrictson · Pull Request #8422 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]

Skip to content

Update changelog_uri in gemspec metadata to GitHub Releases #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mattbrictson
Copy link
Contributor

The gem metadata published to Rubygems points to the CHANGELOG.md file, but this is no longer the official changelog of record. The file says:

Future changelogs have moved to GitHub Releases

This commit updates the gemspec metadata to point to GitHub Releases so that future releases to Rubygems contain the correct URL.

Copy link
codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (2de51ea) to head (8aa8a3e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8422   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         140      140           
  Lines        4029     4029           
=======================================
  Hits         3993     3993           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala self-requested a review August 3, 2024 06:19
The gem metadata published to Rubygems points to the CHANGELOG.md file,
but this is no longer the official changelog of record. The file says:

> Future changelogs have moved to GitHub Releases

This commit updates the gemspec metadata to point to GitHub Releases so
that future releases to Rubygems contain the correct URL.
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javierjulio javierjulio merged commit 59a8627 into activeadmin:master Aug 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0