Test with Ruby 3.0 and Ruby 3.1 #7275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, since this has been done separately, I would like to suggest to use strings instead of numbers for ruby versions, so we can read "3.0" instead of 3 in the details
I have also another question: is Rails 6.1 officially compatible with Ruby 3.1? |
|
👍 I'll switch to strings. Not sure about Rails support, I guess not, I will make sure and whatever not supported. |
e0e40cb to
e8100cb
Compare
affee27 to
9e97359
Compare
Bumps [rails-i18n](https://github.com/svenfuchs/rails-i18n) from 7.0.0 to 7.0.1. - [Release notes](https://github.com/svenfuchs/rails-i18n/releases) - [Changelog](https://github.com/svenfuchs/rails-i18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/svenfuchs/rails-i18n/commits) --- updated-dependencies: - dependency-name: rails-i18n dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Geremia Taglialatela <tagliala.dev@gmail.com>
Co-authored-by: Geremia Taglialatela <tagliala.dev@gmail.com>
Only on Rails 6.0 and 6.1 since Rails 5.2 does not work with it. Co-authored-by: Geremia Taglialatela <tagliala.dev@gmail.com>
To fix did_you_mean warnings on Ruby 3.1.
Since net-smtp is not a default gem anymore, the mail gem needs to add it explicitly as a dependency given that it depends on it, in order to support Ruby 3.1. Until that happens, we can workaround the issue by adding the dependency to our gemfiles.
To use less I18n internals and don't print warnings.
It only seems compatible with Rails 6.1. Rails 6.0 would need Psych 4 support backported. Run lint job also with Ruby 3.1, which involves using Rails 6.1 instead of Rails 6.0 given the above.
9e97359 to
4b3125f
Compare
|
This one should be ready from my side! I want to drop support for Rails 5.2 and Rails 6.0, but I guess that can be done/discussed separately. Also I'm slimming down our CI matrix a bit by running webpacker and turbo links checks only against the latest supported Ruby, so we need to reconfigure our default branch settings to remove some required checks now. |
javierjulio
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to slowly get back to helping out here.
I want to get Ruby 3.0 and Ruby 3.1 officially tested.
Some changes are also proposed separately at #7235 so I added @tagliala as a co-author.