8000 Fix filtering by nested resource by deivid-rodriguez · Pull Request #5816 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Fix filtering by nested resource #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2019
Merged

Fix filtering by nested resource #5816

merged 4 commits into from
Jul 25, 2019

Conversation

deivid-rodriguez
Copy link
Member

After enabling a sample nested resource in #5814, I found a crash in the users page, when filtering by post.

I guess this kind of filtering is pretty uncommon (it always results in a single record), maybe it shouldn't be included by default?

Anyways, this should fix the crash, which by the way looks like this:

    And I press "Filter"                                                              # features/step_definitions/web_steps.rb:24
      undefined method `user' for #<Post:0x000055a5adf3d8d0>
      Did you mean?  super (ActionView::Template::Error)
      ./lib/active_admin/resource/routes.rb:113:in `public_send'
      ./lib/active_admin/resource/routes.rb:113:in `route_instance_params'
      ./lib/active_admin/resource/routes.rb:79:in `instance_path'
      ./lib/active_admin/resource/routes.rb:19:in `route_instance_path'
      ./lib/active_admin/view_helpers/auto_link_helper.rb:29:in `auto_url_for'
      ./lib/active_admin/view_helpers/auto_link_helper.rb:15:in `auto_link'
      ./lib/active_admin/view_helpers/display_helper.rb:78:in `pretty_format'
      ./lib/active_admin/filters/active_sidebar.rb:31:in `block (8 levels) in block'
(...)

@deivid-rodriguez deivid-rodriguez requested a review from a team July 25, 2019 20:53
@javierjulio
Copy link
Member

In regards to the question in the description, I think it would be better that ActiveAdmin didn't render all/any filters by default, instead it would have to be specified explicitly in the file. I've had trouble in the past leaving the defaults so I've been in the habit of always specifying filters on all pages.

javierjulio
javierjulio approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member
@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks! 👌🏻

@javierjulio javierjulio merged commit 7e3eb6e into master Jul 25, 2019
@javierjulio javierjulio deleted the fix_filtering_by_nested_resource branch July 25, 2019 23:02
@deivid-rodriguez deivid-rodriguez mentioned this pull request Jul 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deivid-rodriguez @javierjulio
0