Fix duplicate namespace when using config.pundit_policy_namespace #5762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kwent! Thanks for helping out here. 👍 Can you detail how this issue can be reproduced? I tried on a fresh application and couldn't see the issue, so I think I'm missing some specific setup to make it happen. Also, if you could add a regression test, that would be great. |
|
I can reproduce it now, actually, no need for steps :). I'd like a test though. |
|
Would love to help with a spec but unfortunately i don't have time to set up the environment etc... at the moment. Glad you were able to repro ! |
|
Closing in favor of #5777. Tried to edit this PR but I don't have permission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When using
config.pundit_policy_namespace = :active_adminwhen the object namespace is alreadyActiveAdmin::PagePolicyresults of trying to findActiveAdmin::ActiveAdmin::PagePolicy. Other models insideActiveAdminare fine. Only no models policy asPageare impacted.This PR is fixing that.