8000 [bugFix] Remove comment routes when disabled #5117 by kavithaRajagopalan · Pull Request #5122 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

[bugFix] Remove comment routes when disabled #5117 #5122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[bugFix] Remove comment routes when disabled #5117 #5122

wants to merge 1 commit into from

Conversation

kavithaRajagopalan
Copy link
@kavithaRajagopalan kavithaRajagopalan commented Aug 4, 2017 •
edited by varyonic
Loading

Resolves #5117

Edit: reference linked issue in description

varyonic
varyonic suggested changes Nov 24, 2017
View reviewed changes
Copy link
Contributor
@varyonic varyonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase (re-apply) to the current version of router.rb, I think L.61. Needs a test. I believe it should be possible to enable comments on a resource even if the namespace default is false.

@varyonic
Copy link
Contributor

I’m going to close this since you haven’t responded. Please feel free to update this PR so it can be reconsidered.

@varyonic varyonic closed this Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varyonic varyonic varyonic requested changes

Assignees
No one assigned
Labels
routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavithaRajagopalan @varyonic
0