Properly format boolean values using status_tag #4938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoschilling
approved these changes
Apr 25, 2017
javierjulio
added a commit
to javierjulio/activeadmin
that referenced
this pull request
May 10, 2017
New tests were introduced in activeadmin#4938 (commit 155c919) that checked HTML output but we’ve since changed the class names to be dashed, not underscored.
javierjulio
added a commit
to javierjulio/activeadmin
that referenced
this pull request
Jun 2, 2017
New tests were introduced in activeadmin#4938 (commit 155c919) that checked HTML output but we’ve since changed the class names to be dashed, not underscored.
javierjulio
added a commit
to javierjulio/activeadmin
that referenced
this pull request
Jun 2, 2017
New tests were introduced in activeadmin#4938 (commit 155c919) that checked HTML output but we’ve since changed the class names to be dashed, not underscored.
javierjulio
added a commit
to javierjulio/activeadmin
that referenced
this pull request
Jun 3, 2017
New tests were introduced in activeadmin#4938 (commit 155c919) that checked HTML output but we’ve since changed the class names to be dashed, not underscored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4602
this is very common monkey patch for AA that I'm still using