8000 Enable mention-bot for translations by deivid-rodriguez · Pull Request #4931 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Enable mention-bot for translations #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2017
Merged

Enable mention-bot for translations #4931

merged 1 commit into from
May 2, 2017

Conversation

deivid-rodriguez
Copy link
Member
@deivid-rodriguez deivid-rodriguez commented Apr 22, 2017 •
edited
Loading

I just had a look at #4918.

Obviously we don't speak all the languages activeadmin supports. So I thought we could use mention-bot for this.

With this configuration, once we label a PR with the i18n label, the mention bot will scan previous contributors to the translation and ping them. Theoretically, since I've never actually used it.

Do you want to give it a try?

varyonic
varyonic reviewed Apr 22, 2017
View reviewed changes
Copy link
Contributor
@varyonic varyonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. My one manual effort so far got no response.

@deivid-rodriguez
Copy link
Member Author
deivid-rodriguez commented Apr 22, 2017 •
edited
Loading

Ok. I added this because I thought your manual effort was a good idea and might actually work well. And keeping all translation PRs under a label does no harm anyways.

@deivid-rodriguez
Copy link
Member Author

@Fivell @timoschilling What do you think? Shall I just close this?

@deivid-rodriguez
Copy link
Member Author

I'm going to merge this with @timoschilling's approval. If we find it useless, we can remove it at a later stage.

@activeadmin/collaborators From now on, make sure you tag translation PR's with the i18n label. If this PR works, previous translators should be automatically notified by the "mention-bot".

@deivid-rodriguez deivid-rodriguez merged commit fee94b9 into master May 2, 2017
@deivid-rodriguez deivid-rodriguez deleted the mention_bot branch May 2, 2017 14:56
deivid-rodriguez added a commit that referenced this pull request Jun 17, 2017
@deivid-rodriguez
Revert "Merge pull request #4931 from activeadmin/mention_bot"
f0adedd 
This reverts commit fee94b9, reversing
changes made to c5b7746.

The configuration added is not really working and I came to think
Varyonic was right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varyonic varyonic varyonic left review comments

@timoschilling timoschilling timoschilling approved these changes

@Fivell Fivell Awaiting requested review from Fivell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @timoschilling @varyonic
0