10000 Skip optimization if decorated collection does not support it. by varyonic · Pull Request #4068 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Skip optimization if decorated collection does not support it. #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2015
Merged

Skip optimization if decorated collection does not support it. #4068

merged 1 commit into from
Aug 11, 2015

Conversation

varyonic
Copy link
Contributor

Fixes #4059

timoschilling added a commit that referenced this pull request Aug 11, 2015
@timoschilling
Merge pull request #4068 from varyonic/4059-paginated-array-collection
8032624 
Skip optimization if decorated collection does not support it.
@timoschilling timoschilling merged commit 8032624 into activeadmin:master Aug 11, 2015
@timoschilling
Copy link
Member

👍

@varyonic varyonic deleted the 4059-paginated-array-collection branch August 11, 2015 18:07
@seanlinsley
Copy link
Contributor

Well, this should have had a test with it ;-)

rafaelsales added a commit to rafaelsales/activeadmin that referenced this pull request Apr 3, 2018
@rafaelsales
Revert PR activeadmin#4068. Use pagination_total optimization work wi…
38e2d4c 
…th decorators
@rafaelsales rafaelsales mentioned this pull request Apr 3, 2018
Closed
2 tasks
@rafaelsales
Copy link
Contributor

This causes the optimization to not work when decorate_with is provided, which doesn't really make sense.
I believe this should've been the proper fix for that issue: #5389

@irmela irmela mentioned this pull request Jul 24, 2019
Merged
irmela pushed a commit to irmela/activeadmin that referenced this pull request Jul 31, 2019
Revert activeadmin#4068
d93cef7
irmela pushed a commit to irmela/activeadmin that referenced this pull request Jul 31, 2019
Revert activeadmin#4068
f3fac34
deivid-rodriguez pushed a commit to irmela/activeadmin that referenced this pull request Sep 12, 2019
@deivid-rodriguez
Revert activeadmin#4068
4db2678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varyonic @timoschilling @seanlinsley @rafaelsales
0