Use safe navigation operator in layout helper (#8533)

tagliala · web-flow · commit 25a6b3668e0e · 2024-11-07T20:34:44.000+01:00
Replace a logic `&&` with safe navigation operator now that Ruby < 2.3 support is not required anymore Benchmark (Ruby 3.3.5 x64 / M1 Pro): ``` Comparison (not `nil`): &.: 18787752.0 i/s &&: 17963968.8 i/s - 1.05x (± 0.00) slower Comparison (`nil`): &&: 21343215.5 i/s &.: 20910008.5 i/s - 1.02x (± 0.00) slower ``` Ref: #8530
diff --git a/app/helpers/active_admin/layout_helper.rb b/app/helpers/active_admin/layout_helper.rb
@@ -22,7 +22,7 @@ def html_head_site_title(separator: "-")
 
     def action_items_for_action
       @action_items_for_action ||= begin
-        if active_admin_config && active_admin_config.action_items?
+        if active_admin_config&.action_items?
           active_admin_config.action_items_for(params[:action], self)
         else
           []
@@ -32,7 +32,7 @@ def action_items_for_action
 
     def sidebar_sections_for_action
       @sidebar_sections_for_action ||= begin
-        if active_admin_config && active_admin_config.sidebar_sections?
+        if active_admin_config&.sidebar_sections?
           active_admin_config.sidebar_sections_for(params[:action], self)
         else
           []
