Use safe navigation for pundit_default_policy (#8530)

tagliala · web-flow · commit 006abfcdd9ee · 2024-11-02T23:00:41.000+01:00
Use the safe navigation operator (`&.`) to streamline the `pundit_default_policy` constantization check, removing the need for a redundant `&&`. This change is now possible as the codebase no longer requires Ruby 2.3 support, which did not yet support safe navigation. The previous implementation was added in commit c93f6f4 to ensure compatibility with older Ruby versions. Also add the safe navigation operator to a subsequent usage of `default_policy_class`
diff --git a/lib/active_admin/pundit_adapter.rb b/lib/active_admin/pundit_adapter.rb
@@ -23,7 +23,7 @@ def scope_collection(collection, action = Auth::READ)
       # which means there is no way how to scope other actions
       Pundit.policy_scope!(user, namespace(collection))
     rescue Pundit::NotDefinedError => e
-      if default_policy_class && default_policy_class.const_defined?(:Scope)
+      if default_policy_class&.const_defined?(:Scope)
         default_policy_class::Scope.new(user, collection).resolve
       else
         raise e
@@ -95,7 +95,7 @@ def namespace(object)
     end
 
     def default_policy_class
-      ActiveAdmin.application.pundit_default_policy && ActiveAdmin.application.pundit_default_policy.constantize
+      ActiveAdmin.application.pundit_default_policy&.constantize
     end
 
     def default_policy(subject)
