Update terminology in setup-python #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brcrista
commented
Dec 27, 2019
| @@ -34,7 +34,7 @@ module.exports = | |||
| /******/ // the startup function | |||
| /******/ function startup() { | |||
| /******/ // Load entry module and return exports | |||
| /******/ return __webpack_require__(429); | |||
| /******/ return __webpack_require__(264); | |||
There was a problem hiding this comment.
I ran with version 0.20.5 of ncc.
brcrista
commented
Dec 27, 2019
action.yml
Outdated
| author: 'GitHub' | ||
| inputs: | ||
| python-version: | ||
| description: 'Version range or exact version of a Python version to use, using semvers version range syntax.' | ||
| description: 'Version range or exact version of a Python version to use, using SemVer's version range syntax.' |
There was a problem hiding this comment.
SemVer stylizes its name as such. See https://semver.org/#semantic-versioning-specification-semver
brcrista
commented
Dec 27, 2019
| @@ -1,7 +1,7 @@ | |||
| extends: default | |||
|
|
|||
| rules: | |||
| # 80 chars should be enough, but don't fail if a line is longer | |||
| # 120 chars should be enough, but don't fail if a line is longer | |||
There was a problem hiding this comment.
I had tried spreading the description, etc., across multiple lines, but I decided it would probably be better to raise the limit. Monitors have gotten bigger since the days of the 80-char guideline, so I think 120 is a good number today.
|
@konradpabjan I just noticed we don't run the main workflow on pull requests. Do you want me to enable it? |
|
@konradpabjan can you merge? I don't have write access to this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the comments are using outdated terminology. I also took the chance to touch up the contributor guidelines.