Log npm & yarn versions #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was just looking for this. Was hoping this action would log info similar to |
|
I think we should protect the outputting of the version(s) with io.which call. e.g. yarn may or may not be installed. even in the case where a version spec could not be met it may not be installed. could make into a common function execIfexist(tool, arg). |
6a1871c to
f69d468
Compare
|
@bryanmacfarlane i've implemented your suggested changes. Could you take another look at this PR? |
|
Hello everyone. I'm going to close the pull request in favour of this #368 |
deining
pushed a commit
to deining/setup-node
that referenced
this pull request
Nov 9, 2023
…ions#76) Bumps [all-contributors-cli](https://github.com/all-contributors/all-contributors-cli) from 6.17.2 to 6.19.0. - [Release notes](https://github.com/all-contributors/all-contributors-cli/releases) - [Commits](all-contributors/cli@v6.17.2...v6.19.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful debug info - IMHO makes sense to always include it.