8000 fix: add arch to cache key by Zxilly · Pull Request #664 · actions/setup-java · GitHub
[go: up one dir, main page]
Skip to content

fix: add arch to cache key #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: add arch to cache key #664

merged 1 commit into from
Sep 19, 2024

Conversation

Zxilly
Copy link
Contributor
@Zxilly Zxilly commented Jul 25, 2024

Description:

GitHub has added the arm64 runner, so arch should be used as part of the cache key. Otherwise, if there are macos-13 macos-14 running at the same time, the late executor will get the wrong cache.

Related issue:

actions/setup-python#896

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@Zxilly Zxilly requested a review from a team as a code owner July 25, 2024 07:56
@HarithaVattikuti HarithaVattikuti merged commit 40b9536 into actions:main Sep 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarithaVattikuti HarithaVattikuti HarithaVattikuti approved these changes

@aparnajyothi-y aparnajyothi-y aparnajyothi-y approved these changes

@mahabaleshwars mahabaleshwars mahabaleshwars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zxilly @HarithaVattikuti @aparnajyothi-y @mahabaleshwars
0