Match filename extension only at the end of the filename #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping... |
Scoppio
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Seen to solve problem with extension being found in the wrong place.
|
A workaround until this PR is merged is to use the @giltene's fork: - name: Set up JDK 11
uses: giltene/setup-java@master
with:
java-version: 11 |
Closed
Contributor
Author
|
@damccorm, @stephenmichaelf can one of you review this change and hopefully merge it? We would really like to put .sig files back where they belong on the Zulu cdn, and this is what is blocking that right now... |
|
@bryanmacfarlane could you triage appropriately? |
Member
* Match extension only at end of line * Add optional java-package parameter (support jre, jdk, and jdk+fx)
Add java-package parameter to action, support jre, jdk, and jdk+fx (#1)
Contributor
Author
|
PR #27 includes this change with a cleaner history, so I’m closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the matching for filename extensions to only match extensions at the end of the filename, and ignore false matches with the same pattern in the middle of the name. This avoids wrongly matching .tar.gz.sig and zip.sig files in the CDN.
The change will prevent issues like #23 happening in the future if/as .sig files are added on the CDN. For the time being, the Zulu CDN has been cleansed of .sig files to avoid this issue, but we would like to be able to safely .sig files back up once this change makes it into a 1.x version of setup-java...
I have verified this change the entire range of Java versions (6, 7, 8, 9, 10, 11, 12, 13), update levels, and OS platforms available on the CDN at this point in time.