8000 Fix PR test workflow for forks by robyoung · Pull Request #117 · actions/github-script · GitHub
[go: up one dir, main page]
Skip to content

Fix PR test workflow for forks #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix PR test workflow for forks #117

merged 1 commit into from
Feb 26, 2021

Conversation

robyoung
Copy link
Contributor

No description provided.

@robyoung robyoung requested a review from a team February 23, 2021 09:21
@robyoung
Fix PR test workflow for forks
58e7e1d 
When the workflow is triggered from a fork the permissions for the
`GITHUB_TOKEN` are read-only. This chane skips the write operations if
we're running from a fork.

See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories
@robyoung robyoung force-pushed the fix-pull-request-test-for-forks branch from ec3d343 to 58e7e1d Compare February 23, 2021 09:39
@robyoung robyoung changed the title wip: see what is coming out Fix PR test workflow for forks Feb 23, 2021
joshmgross
joshmgross approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor
@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshmgross joshmgross merged commit e86864d into actions:main Feb 26, 2021
@robyoung robyoung deleted the fix-pull-request-test-for-forks branch February 27, 2021 07:54
robyoung added a commit to robyoung/github-script that referenced this pull request Mar 2, 2021
@robyoung
Fix typo from actions#117
77c8747 
I accidentally removed two lines I did not intend to. This would only
break for PRs opened on the repo directly.
joshmgross added a commit that referenced this pull request Mar 3, 2021
@joshmgross
Merge pull request #121 from robyoung/fix-previous-broken-pr
3d069b2 
Fix typo from #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmgross joshmgross joshmgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robyoung @joshmgross
0