10000 Unpatch symfony console by danepowell · Pull Request #500 · acquia/cli · GitHub
[go: up one dir, main page]
Skip to content

Unpatch symfony console #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Unpatch symfony console #500

wants to merge 1 commit into from

Conversation

danepowell
Copy link
Contributor

Symfony 5.2.6 contains the changes that we were previously applying via this patch.

@grasmash
Copy link
Contributor

Weird, why would it work with the patch but not in the new version where the same exact changes are committed?

@danepowell
Copy link
Contributor Author
danepowell commented Mar 29, 2021 •
edited
Loading

I think there were other Symfony updates besides just our PRs. One of them appears to have broken Progress Bars. This wouldn't be the first time that a "patch" update introduced a breaking change.

@grasmash grasmash mentioned this pull request Mar 29, 2021
Closed
@grasmash
Copy link
Contributor

symfony/symfony#40633

@danepowell danepowell marked this pull request as draft April 1, 2021 15:38
@grasmash
Copy link
Contributor
grasmash commented Apr 8, 2021

A fix was merged upstream. Waiting for new console release.

@anavarre
Copy link
Contributor
anavarre commented Apr 29, 2021 •
edited
Loading

Fix is in https://github.com/symfony/symfony/releases/tag/v5.3.0-BETA1 - Do we want to try it out or wait for the final release?

@danepowell
Copy link
Contributor Author

Considering that what blocked us on this PR was a breaking change in a stable patch release, I think the last think we should attempt is update to a beta 😄

@danepowell
Copy link
Contributor Author

There's no need to keep a PR open for this, we'll wait for a new release and track via the internal ticket.

@danepowell danepowell closed this Apr 30, 2021
@danepowell danepowell deleted the unpatch-symfony branch September 22, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danepowell @grasmash @anavarre
0